[Payment Request] Invalidates cached autofill profile after it is updated.

[Payment Request] Invalidates cached autofill profile after it is updated.

BUG=602666
Review-Url: https://codereview.chromium.org/2929673003
Cr-Commit-Position: refs/heads/master@{#477994}
Committed: https://chromium.googlesource.com/chromium/src/+/04f1487613b0a255d0f89909fa04a22de4052eab

[Moe, 2017-06-08 04:23:12]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 04:23:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 05:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 05:29:43]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-06-08 13:23:07]

mahmadi@chromium.org changed reviewers:
+ rouslan@chromium.org

[Moe, 2017-06-08 13:23:08]

Hi Rouslan, Please take a look.

[please use gerrit instead, 2017-06-08 14:25:06]

LGTM % comment

https://codereview.chromium.org/2929673003/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
(right):

https://codereview.chromium.org/2929673003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm:126:
std::unique_ptr<MockPaymentsProfileComparator> profile_comparator_;
You must declare this before payment_request_ (2 lines above) because the order
of destruction will make this object deleted before payment_request_ is deleted.
This will violate your requirement that the parameter of SetProfileComparator()
outlives the callee.

[Moe, 2017-06-08 15:06:52]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-06-08 15:06:53]

Thank you Rouslan!

https://codereview.chromium.org/2929673003/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
(right):

https://codereview.chromium.org/2929673003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm:126:
std::unique_ptr<MockPaymentsProfileComparator> profile_comparator_;
On 2017/06/08 at 14:25:06, rouslan wrote:
> You must declare this before payment_request_ (2 lines above) because the
order of destruction will make this object deleted before payment_request_ is
deleted. This will violate your requirement that the parameter of
SetProfileComparator() outlives the callee.

Done. Also moved personal_data_manager_ after pref_service_ for the same reason.

[Moe, 2017-06-08 15:06:53]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2929673003/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-06-08 15:07:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 16:40:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496934412747640,
"parent_rev": "eaeed3d8d7847391e15200a6a8779afd2e587c7d", "commit_rev":
"04f1487613b0a255d0f89909fa04a22de4052eab"}

[commit-bot: I haz the power, 2017-06-08 16:40:45]

Description was changed from

==========
[Payment Request] Invalidates cached autofill profile after it is updated.

BUG=602666
==========

to

==========
[Payment Request] Invalidates cached autofill profile after it is updated.

BUG=602666

Review-Url: https://codereview.chromium.org/2929673003
Cr-Commit-Position: refs/heads/master@{#477994}
Committed:
https://chromium.googlesource.com/chromium/src/+/04f1487613b0a255d0f89909fa04...
==========

[commit-bot: I haz the power, 2017-06-08 16:40:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/04f1487613b0a255d0f89909fa04...