Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2929663002: [CRD iOS] Fix color scheme and other UI issues (Closed)

Created:
3 years, 6 months ago by Yuwei
Modified:
3 years, 6 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Fix color scheme and other UI issues This CL basically fixes the color scheme on the host list and the connection view so that it better matches the UX mocks. This CL also makes the host list dismiss all snack bars before opening the connection view. BUG=728280 Review-Url: https://codereview.chromium.org/2929663002 Cr-Commit-Position: refs/heads/master@{#477822} Committed: https://chromium.googlesource.com/chromium/src/+/586612f5cb614fadb37cb05602dba204154e645e

Patch Set 1 #

Total comments: 9

Patch Set 2 : resolve feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -15 lines) Patch
M remoting/ios/app/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/ios/app/client_connection_view_controller.mm View 1 7 chunks +9 lines, -4 lines 0 comments Download
M remoting/ios/app/host_collection_view_cell.mm View 1 3 chunks +4 lines, -5 lines 0 comments Download
M remoting/ios/app/pin_entry_view.mm View 1 chunk +2 lines, -1 line 0 comments Download
A remoting/ios/app/remoting_theme.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
A remoting/ios/app/remoting_theme.mm View 1 1 chunk +49 lines, -0 lines 0 comments Download
M remoting/ios/app/remoting_view_controller.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yuwei
PTAL thanks! https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json File remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json (right): https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json#newcode14 remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json:14: "idiom" : "universal", XCode attempts to add ...
3 years, 6 months ago (2017-06-07 20:54:09 UTC) #2
nicholss
lgtm Minor nits. https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/client_connection_view_controller.mm File remoting/ios/app/client_connection_view_controller.mm (right): https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/client_connection_view_controller.mm#newcode17 remoting/ios/app/client_connection_view_controller.mm:17: #import "remoting/ios/app/remoting_styles.h" Most apps call this ...
3 years, 6 months ago (2017-06-07 21:01:42 UTC) #3
Yuwei
Thanks! https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/client_connection_view_controller.mm File remoting/ios/app/client_connection_view_controller.mm (right): https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/client_connection_view_controller.mm#newcode17 remoting/ios/app/client_connection_view_controller.mm:17: #import "remoting/ios/app/remoting_styles.h" On 2017/06/07 21:01:41, nicholss wrote: > ...
3 years, 6 months ago (2017-06-07 22:25:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929663002/40001
3 years, 6 months ago (2017-06-07 22:26:03 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 00:20:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/586612f5cb614fadb37cb05602db...

Powered by Google App Engine
This is Rietveld 408576698