[CRD iOS] Fix color scheme and other UI issues

[CRD iOS] Fix color scheme and other UI issues

This CL basically fixes the color scheme on the host list and the connection
view so that it better matches the UX mocks.

This CL also makes the host list dismiss all snack bars before opening the
connection view.

BUG=728280
Review-Url: https://codereview.chromium.org/2929663002
Cr-Commit-Position: refs/heads/master@{#477822}
Committed: https://chromium.googlesource.com/chromium/src/+/586612f5cb614fadb37cb05602dba204154e645e

[Yuwei, 2017-06-07 20:54:08]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-06-07 20:54:09]

PTAL thanks!

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/resources/...
File
remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json
(right):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/resources/...
remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json:14:
"idiom" : "universal",
XCode attempts to add back the nonexisting 3x image. Anyway...

[nicholss, 2017-06-07 21:01:42]

lgtm

Minor nits.

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/client_con...
File remoting/ios/app/client_connection_view_controller.mm (right):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/client_con...
remoting/ios/app/client_connection_view_controller.mm:17: #import
"remoting/ios/app/remoting_styles.h"
Most apps call this theme, ie remoting_theme

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/pin_entry_...
File remoting/ios/app/pin_entry_view.mm (left):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/pin_entry_...
remoting/ios/app/pin_entry_view.mm:49: [_pinButton setTitle:@"+"
forState:UIControlStateNormal];
No more + ?

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/remoting_s...
File remoting/ios/app/remoting_styles.mm (right):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/remoting_s...
remoting/ios/app/remoting_styles.mm:11: static UIColor* kHostListBackgroundColor
=
There is a more direct way to do this that would help when this file gets long.
I will pm it to you.

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/resources/...
File
remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json
(right):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/resources/...
remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json:14:
"idiom" : "universal",
On 2017/06/07 20:54:09, Yuwei wrote:
> XCode attempts to add back the nonexisting 3x image. Anyway...

yeah it will just use the 2x and scale it.

[Yuwei, 2017-06-07 22:23:59]

Patchset #2 (id:20001) has been deleted

[Yuwei, 2017-06-07 22:25:23]

Thanks!

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/client_con...
File remoting/ios/app/client_connection_view_controller.mm (right):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/client_con...
remoting/ios/app/client_connection_view_controller.mm:17: #import
"remoting/ios/app/remoting_styles.h"
On 2017/06/07 21:01:41, nicholss wrote:
> Most apps call this theme, ie remoting_theme

Done.

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/pin_entry_...
File remoting/ios/app/pin_entry_view.mm (left):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/pin_entry_...
remoting/ios/app/pin_entry_view.mm:49: [_pinButton setTitle:@"+"
forState:UIControlStateNormal];
On 2017/06/07 21:01:42, nicholss wrote:
> No more + ?

Yep. Replaced by ->

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/remoting_s...
File remoting/ios/app/remoting_styles.mm (right):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/remoting_s...
remoting/ios/app/remoting_styles.mm:11: static UIColor* kHostListBackgroundColor
=
On 2017/06/07 21:01:42, nicholss wrote:
> There is a more direct way to do this that would help when this file gets
long.
> I will pm it to you.

Done.

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/resources/...
File
remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json
(right):

https://codereview.chromium.org/2929663002/diff/1/remoting/ios/app/resources/...
remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json:14:
"idiom" : "universal",
On 2017/06/07 21:01:42, nicholss wrote:
> On 2017/06/07 20:54:09, Yuwei wrote:
> > XCode attempts to add back the nonexisting 3x image. Anyway...
> 
> yeah it will just use the 2x and scale it.

Acknowledged.

[Yuwei, 2017-06-07 22:25:37]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-06-07 22:25:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
nicholss@chromium.org
Link to the patchset: https://codereview.chromium.org/2929663002/#ps40001
(title: "resolve feedback")

[commit-bot: I haz the power, 2017-06-07 22:26:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 00:19:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496874337397740,
"parent_rev": "2b07f89b0ab15ff76a01ede77d347e90bdcc6582", "commit_rev":
"6bc78f16e24404086bc34791531f6ec0ab1c5bea"}

[commit-bot: I haz the power, 2017-06-08 00:19:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496874337397740,
"parent_rev": "2ed4b97e17e5da8602de52c9ad1c8cb4eb67a9fe", "commit_rev":
"586612f5cb614fadb37cb05602dba204154e645e"}

[commit-bot: I haz the power, 2017-06-08 00:20:03]

Description was changed from

==========
[CRD iOS] Fix color scheme and other UI issues

This CL basically fixes the color scheme on the host list and the connection
view so that it better matches the UX mocks.

This CL also makes the host list dismiss all snack bars before opening the
connection view.

BUG=728280
==========

to

==========
[CRD iOS] Fix color scheme and other UI issues

This CL basically fixes the color scheme on the host list and the connection
view so that it better matches the UX mocks.

This CL also makes the host list dismiss all snack bars before opening the
connection view.

BUG=728280

Review-Url: https://codereview.chromium.org/2929663002
Cr-Commit-Position: refs/heads/master@{#477822}
Committed:
https://chromium.googlesource.com/chromium/src/+/586612f5cb614fadb37cb05602db...
==========

[commit-bot: I haz the power, 2017-06-08 00:20:05]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/586612f5cb614fadb37cb05602db...