Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2929563003: Add fail to timeout layout test expecatations (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
jwd
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add fail to timeout layout test expecatations I allowed these to timeout when rebaselining, which caused them to not get rebaselined, causing them to start failing now. BUG=730267 Review-Url: https://codereview.chromium.org/2929563003 Cr-Commit-Position: refs/heads/master@{#477839} Committed: https://chromium.googlesource.com/chromium/src/+/e88b4570354eca47bc65a98bbba6013f73c6c816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ccameron
ptal -- oops.
3 years, 6 months ago (2017-06-07 20:21:12 UTC) #3
jwd
lgtm
3 years, 6 months ago (2017-06-07 20:26:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929563003/1
3 years, 6 months ago (2017-06-07 23:28:53 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 00:57:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e88b4570354eca47bc65a98bbba6...

Powered by Google App Engine
This is Rietveld 408576698