Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 2929543002: Request Composition Range Updates for Focused GuestViews based on BrowserPlugins (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index d2ba7285f9fef018ca93c271d64997aa84c1f3cb..e6fad0214511f414df5239118da724c0b1d3e12c 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -650,8 +650,14 @@ void BrowserPluginGuest::SendTextInputTypeChangedToView(
return;
}
- if (last_text_input_state_.get())
+ if (last_text_input_state_.get()) {
guest_rwhv->TextInputStateChanged(*last_text_input_state_);
+ if (auto* rwh =
+ RenderWidgetHostImpl::From(guest_rwhv->GetRenderWidgetHost())) {
+ rwh->RequestCompositionUpdates(
Charlie Reis 2017/06/06 22:52:13 Can you add a comment for why this is needed? I d
EhsanK 2017/06/09 19:09:10 Yes I should have put a comment here. Done!
+ false, last_text_input_state_->type != ui::TEXT_INPUT_TYPE_NONE);
+ }
+ }
}
void BrowserPluginGuest::DidFinishNavigation(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698