Request Composition Range Updates for Focused GuestViews based on BrowserPlugins

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 632 matching lines @@
     // embedder shutdown or when the embedder navigates to a different page.
     // The call stack is roughly:
     // BrowserPluginGuest::SetFocus()
     // content::InterstitialPageImpl::Hide()
     // content::InterstitialPageImpl::DontProceed().
     //
     // TODO(lazyboy): Write a WebUI test once http://crbug.com/463674 is fixed.
     return;
   }
 
-  if (last_text_input_state_.get())
+  if (last_text_input_state_.get()) {
     guest_rwhv->TextInputStateChanged(*last_text_input_state_);
+    if (auto* rwh =
+            RenderWidgetHostImpl::From(guest_rwhv->GetRenderWidgetHost())) {
+      rwh->RequestCompositionUpdates(

[Charlie Reis, 2017/06/06 22:52:13]

Can you add a comment for why this is needed?  I don't immediately understand
from context.

[EhsanK, 2017/06/09 19:09:10]

Yes I should have put a comment here. Done!

+          false, last_text_input_state_->type != ui::TEXT_INPUT_TYPE_NONE);
+    }
+  }
 }
 
 void BrowserPluginGuest::DidFinishNavigation(
     NavigationHandle* navigation_handle) {
   if (navigation_handle->HasCommitted())
     RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
 }
 
 void BrowserPluginGuest::RenderViewReady() {
   if (GuestMode::IsCrossProcessFrameGuest(GetWebContents()))
@@ skipping 407 matching lines @@
           range, character_bounds);
 }
 #endif
 
 void BrowserPluginGuest::SetContextMenuPosition(const gfx::Point& position) {
   if (delegate_)
     delegate_->SetContextMenuPosition(position);
 }
 
 }  // namespace content