Fill has_password_field for password reuse ping

components/safe_browsing/password_protection/password_protection_request.h

Index: components/safe_browsing/password_protection/password_protection_request.h
diff --git a/components/safe_browsing/password_protection/password_protection_request.h b/components/safe_browsing/password_protection/password_protection_request.h
index 2bb4499ebd267c1ab1b16a65246d593c521d4f5f..e3bb79b2b655880c8fa91132ba46a41228cd1ed6 100644
--- a/components/safe_browsing/password_protection/password_protection_request.h
+++ b/components/safe_browsing/password_protection/password_protection_request.h
@@ -46,6 +46,7 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
                             const GURL& password_form_frame_url,
                             const std::string& saved_domain,
                             LoginReputationClientRequest::TriggerType type,
+                            bool has_password_field,
                             PasswordProtectionService* pps,
                             int request_timeout_in_ms);
 
@@ -130,6 +131,9 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
   // If this request is for unfamiliar login page or for a password reuse event.
   const LoginReputationClientRequest::TriggerType request_type_;
 
+  // If there is a password field on the page.
+  const bool has_password_field;

[lpz, 2017/06/07 13:54:24]

include the trailing _

nit: also consider renaming so it doesn't start with "has_" since that makes it
look like you're checking for the presence of a proto field called
"password_field". Although that might not be a huge issue in the chrome
codebase. Perhaps "password_field_exists_"?

[Jialiu Lin, 2017/06/07 21:12:33]

Ah, can't believe I made this mistake. And "password_field_exists_" sounds much
better. Thanks for this suggestion!

+
   // When request is sent.
   base::TimeTicks request_start_time_;