Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2929493002: Plumb PaintImage for the img.decode instead of SkImage. (Closed)

Created:
3 years, 6 months ago by vmpstr
Modified:
3 years, 6 months ago
Reviewers:
pdr., enne (OOO)
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb PaintImage for the img.decode instead of SkImage. This patch plumbs PaintImage to the compositor from the img.decode API, instead of SkImage, since we need to know the paint image id to properly ensure that we don't checker image these images. R=pdr@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2929493002 Cr-Commit-Position: refs/heads/master@{#477385} Committed: https://chromium.googlesource.com/chromium/src/+/bf56d56bd4568c1d4828b955565cb83fc22f63ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M cc/tiles/decoded_image_tracker.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/tiles/decoded_image_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiles/decoded_image_tracker_unittest.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.h View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebViewBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
vmpstr
Please take a look.
3 years, 6 months ago (2017-06-06 18:00:59 UTC) #4
pdr.
On 2017/06/06 at 18:00:59, vmpstr wrote: > Please take a look. LGTM
3 years, 6 months ago (2017-06-06 18:05:33 UTC) #5
enne (OOO)
lgtm
3 years, 6 months ago (2017-06-06 18:08:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929493002/1
3 years, 6 months ago (2017-06-06 18:11:35 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 20:16:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf56d56bd4568c1d4828b955565c...

Powered by Google App Engine
This is Rietveld 408576698