Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2929483003: VR: Further split common code from Android-specific code. (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Further split common code from Android-specific code. Separate the UI to browser interface, to drop all Android awareness. Also, fix a few instances of code that doesn't compile on linux. The only thing needed now to compile tests on linux is a reference from src/BUILD.gn, and exposing a few libraries and string resources exposed to linux. BUG=727396 Change-Id: I7c5a840b0820617a674b9668ebbb538e0ea62cfc Reviewed-on: https://chromium-review.googlesource.com/521325 Commit-Queue: Christopher Grant <cjgrant@chromium.org>; Reviewed-by: Michael Thiessen <mthiesse@chromium.org>; Reviewed-by: Yash Malik <ymalik@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#477304} Review-Url: https://codereview.chromium.org/2929483003 . Cr-Commit-Position: refs/branch-heads/3112@{#193} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/b7d24a4f80036ac2bfdaf43b6394e7f2461f5bdd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -125 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 4 chunks +6 lines, -1 line 0 comments Download
A + chrome/browser/android/vr_shell/gl_browser_interface.h View 3 chunks +7 lines, -16 lines 0 comments Download
A chrome/browser/android/vr_shell/ui_browser_interface.h View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/ui_element_unittest.cc View 4 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc View 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/android/vr_shell/vr_browser_interface.h View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.h View 4 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cjgrant
3 years, 6 months ago (2017-06-06 18:18:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7d24a4f80036ac2bfdaf43b6394e7f2461f5bdd.

Powered by Google App Engine
This is Rietveld 408576698