Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7942)

Unified Diff: chrome_elf/breakpad.cc

Issue 292933002: For Chrome builds, only upload crashes when the build is official. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_breakpad_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_elf/breakpad.cc
===================================================================
--- chrome_elf/breakpad.cc (revision 271530)
+++ chrome_elf/breakpad.cc (working copy)
@@ -102,7 +102,7 @@
void InitializeCrashReporting() {
wchar_t exe_path[MAX_PATH] = {};
- if(!::GetModuleFileName(NULL, exe_path, arraysize(exe_path)))
+ if (!::GetModuleFileName(NULL, exe_path, arraysize(exe_path)))
return;
// Disable the message box for assertions.
@@ -123,13 +123,10 @@
MiniDumpWithIndirectlyReferencedMemory); // Get memory referenced by
// stack.
- // Convert #define to a variable so that we can use if() rather than
- // #if below and so at least compile-test the Chrome code in
- // Chromium builds.
-#if defined(GOOGLE_CHROME_BUILD)
- bool is_chrome_build = true;
+#if defined(GOOGLE_CHROME_BUILD) && defined(OFFICIAL_BUILD)
+ bool is_official_chrome_build = true;
#else
- bool is_chrome_build = false;
+ bool is_official_chrome_build = false;
#endif
base::string16 pipe_name;
@@ -139,8 +136,9 @@
if (!use_policy && IsHeadless()) {
pipe_name = kChromePipeName;
- } else if (use_policy ? enabled_by_policy :
- (is_chrome_build && AreUsageStatsEnabled(exe_path))) {
+ } else if (use_policy ?
+ enabled_by_policy :
+ (is_official_chrome_build && AreUsageStatsEnabled(exe_path))) {
// Build the pipe name. It can be one of:
// 32-bit system: \\.\pipe\GoogleCrashServices\S-1-5-18
// 32-bit user: \\.\pipe\GoogleCrashServices\<user SID>
« no previous file with comments | « chrome/app/chrome_breakpad_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698