Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: chrome/app/chrome_breakpad_client.cc

Issue 292933002: For Chrome builds, only upload crashes when the build is official. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_elf/breakpad.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_breakpad_client.cc
===================================================================
--- chrome/app/chrome_breakpad_client.cc (revision 271530)
+++ chrome/app/chrome_breakpad_client.cc (working copy)
@@ -334,13 +334,10 @@
}
bool ChromeBreakpadClient::GetCollectStatsConsent() {
- // Convert #define to a variable so that we can use if() rather than
- // #if below and so at least compile-test the Chrome code in
- // Chromium builds.
-#if defined(GOOGLE_CHROME_BUILD)
- bool is_chrome_build = true;
+#if defined(GOOGLE_CHROME_BUILD) && defined(OFFICIAL_BUILD)
+ bool is_official_chrome_build = true;
#else
- bool is_chrome_build = false;
+ bool is_official_chrome_build = false;
#endif
#if defined(OS_CHROMEOS)
@@ -357,9 +354,10 @@
// TODO(jcivelli): we should not initialize the crash-reporter when it was not
// enabled. Right now if it is disabled we still generate the minidumps but we
// do not upload them.
- return is_chrome_build;
+ return is_official_chrome_build;
#else // !defined(OS_ANDROID)
- return is_chrome_build && GoogleUpdateSettings::GetCollectStatsConsent();
+ return is_official_chrome_build &&
+ GoogleUpdateSettings::GetCollectStatsConsent();
#endif // defined(OS_ANDROID)
}
« no previous file with comments | « no previous file | chrome_elf/breakpad.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698