Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 29293003: DM: add --writePath (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
bsalomon, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

DM: add --writePath For fun, make the output prettier, hiding ", N failures" unless there is one. BUG= R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11867

Patch Set 1 #

Patch Set 2 : reup #

Patch Set 3 : tweaks #

Patch Set 4 : directory per config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -3 lines) Patch
M dm/DMCpuTask.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M dm/DMGpuTask.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M dm/DMReplayTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMReporter.cpp View 1 2 1 chunk +7 lines, -1 line 0 comments Download
A dm/DMWriteTask.h View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A dm/DMWriteTask.cpp View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download
M dm/README View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/dm.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
I know you guys use this feature of GM a lot, so I figured you'd ...
7 years, 2 months ago (2013-10-18 16:12:38 UTC) #1
bsalomon
On 2013/10/18 16:12:38, mtklein wrote: > I know you guys use this feature of GM ...
7 years, 2 months ago (2013-10-18 16:31:42 UTC) #2
mtklein
On 2013/10/18 16:31:42, bsalomon wrote: > On 2013/10/18 16:12:38, mtklein wrote: > > I know ...
7 years, 2 months ago (2013-10-18 20:10:04 UTC) #3
bsalomon
lgtm
7 years, 2 months ago (2013-10-18 20:32:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/29293003/110001
7 years, 2 months ago (2013-10-18 20:35:07 UTC) #5
mtklein
7 years, 2 months ago (2013-10-18 20:52:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r11867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698