Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2929163002: DevTools: add use strict in check gn (Closed)

Created:
3 years, 6 months ago by chenwilliam
Modified:
3 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add use strict in check gn Needed for node v4 (I previously tested node w/ v7 which doesn't need it). BUG=none Review-Url: https://codereview.chromium.org/2929163002 Cr-Commit-Position: refs/heads/master@{#478384} Committed: https://chromium.googlesource.com/chromium/src/+/cdaa8aeeaab0da73ea69ee456228fadd131a038e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/scripts/check_gn.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
chenwilliam
ptal
3 years, 6 months ago (2017-06-09 18:37:56 UTC) #2
pfeldman
lgtm
3 years, 6 months ago (2017-06-09 18:38:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929163002/1
3 years, 6 months ago (2017-06-09 18:41:29 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 20:02:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cdaa8aeeaab0da73ea69ee456228...

Powered by Google App Engine
This is Rietveld 408576698