Fix crashing TabPersistentStoreTest.

Fix crashing TabPersistentStoreTest.

Migrates TabPersistentStoreTest to JUnit4, and uses
ChromeBrowserTestRule to ensure we no longer receive crashes related to
AccountManagerHelper.

Also runs appropriate portions of the tests on the UI thread using
ThreadUtils. This is the first of many fixes for several tests that are
failing in the same way.

BUG=710901
Review-Url: https://codereview.chromium.org/2929133003
Cr-Commit-Position: refs/heads/master@{#479079}
Committed: https://chromium.googlesource.com/chromium/src/+/9c9874f171dcdc89467c07d06b5a0d99316cbbad

[troyhildebrandt, 2017-06-09 16:10:26]

Description was changed from

==========
Fix crashing TabPersistentStoreTest.

Migrates TabPersistentStoreTest to JUnit4, and uses
ChromeBrowserTestRule to ensure we no longer receive crashes related to
AccountManagerHelper.

Also runs appropriate portions of the tests on the UI thread using
ThreadUtils. This is the first of many fixes for several tests that are
failing in the same way.

BUG=710901
==========

to

==========
Fix crashing TabPersistentStoreTest.

Migrates TabPersistentStoreTest to JUnit4, and uses
ChromeBrowserTestRule to ensure we no longer receive crashes related to
AccountManagerHelper.

Also runs appropriate portions of the tests on the UI thread using
ThreadUtils. This is the first of many fixes for several tests that are
failing in the same way.

BUG=710901
==========

[troyhildebrandt, 2017-06-09 16:10:26]

thildebr@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2017-06-12 17:21:12]

lgtm

[troyhildebrandt, 2017-06-12 17:24:23]

The CQ bit was checked by thildebr@chromium.org

[commit-bot: I haz the power, 2017-06-12 17:24:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 17:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 17:44:22]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[troyhildebrandt, 2017-06-12 17:58:29]

The CQ bit was checked by thildebr@chromium.org

[troyhildebrandt, 2017-06-12 17:58:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2929133003/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-06-12 17:59:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 18:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 18:22:03]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[troyhildebrandt, 2017-06-12 18:30:08]

The CQ bit was checked by thildebr@chromium.org

[troyhildebrandt, 2017-06-12 18:30:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2929133003/#ps60001
(title: "Hopefully caught all the changes to mChromeActivity this time...")

[commit-bot: I haz the power, 2017-06-12 18:31:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:30:37]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[troyhildebrandt, 2017-06-12 21:43:31]

The CQ bit was checked by thildebr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 21:44:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 23:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 23:20:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[troyhildebrandt, 2017-06-13 16:59:02]

The CQ bit was checked by thildebr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 16:59:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:04:09]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[troyhildebrandt, 2017-06-13 17:34:07]

The CQ bit was checked by thildebr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 17:34:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 18:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 18:20:18]

Dry run: This issue passed the CQ dry run.

[troyhildebrandt, 2017-06-13 18:36:40]

The CQ bit was checked by thildebr@chromium.org

[troyhildebrandt, 2017-06-13 18:36:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2929133003/#ps100001
(title: "Maybe now?")

[commit-bot: I haz the power, 2017-06-13 18:37:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 18:43:47]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1497379000572510,
"parent_rev": "06e2d539179523cf3ce6041128bc5e8977cf7e85", "commit_rev":
"9c9874f171dcdc89467c07d06b5a0d99316cbbad"}

[commit-bot: I haz the power, 2017-06-13 18:43:56]

Description was changed from

==========
Fix crashing TabPersistentStoreTest.

Migrates TabPersistentStoreTest to JUnit4, and uses
ChromeBrowserTestRule to ensure we no longer receive crashes related to
AccountManagerHelper.

Also runs appropriate portions of the tests on the UI thread using
ThreadUtils. This is the first of many fixes for several tests that are
failing in the same way.

BUG=710901
==========

to

==========
Fix crashing TabPersistentStoreTest.

Migrates TabPersistentStoreTest to JUnit4, and uses
ChromeBrowserTestRule to ensure we no longer receive crashes related to
AccountManagerHelper.

Also runs appropriate portions of the tests on the UI thread using
ThreadUtils. This is the first of many fixes for several tests that are
failing in the same way.

BUG=710901

Review-Url: https://codereview.chromium.org/2929133003
Cr-Commit-Position: refs/heads/master@{#479079}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c9874f171dcdc89467c07d06b5a...
==========

[commit-bot: I haz the power, 2017-06-13 18:43:58]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9c9874f171dcdc89467c07d06b5a...