Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2928993004: Revert of [Android Refactor] Merge WebappDataStorage#LAST_USED_UNSET and LAST_USED_INVALID (Closed)

Created:
3 years, 6 months ago by jbudorick
Modified:
3 years, 6 months ago
Reviewers:
dominickn, pkotwicz
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android Refactor] Merge WebappDataStorage#LAST_USED_UNSET and LAST_USED_INVALID (patchset #1 id:1 of https://codereview.chromium.org/2927723003/ ) Reason for revert: Spec revert due to significantly increased flakiness in one of the WebApkUpdateManagerTests: https://bugs.chromium.org/p/chromium/issues/detail?id=731485 Original issue's description: > [Android Refactor] Merge WebappDataStorage#LAST_USED_UNSET and LAST_USED_INVALID > > Having both LAST_USED_UNSET and LAST_USED_INVALID is unnecessary as > - the "last_used" SharedPreference should never be set to LAST_USED_INVALID > - there isn't any logic which checks whether "last_used" is LAST_USED_INVALID > > Additionally, this CL renames LAST_USED_INVALID to TIMESTAMP_INVALID as > the getters for several time-based SharedPreferences other than "last_used" > return LAST_USED_INVALID if the preference is unset. > > BUG=None > > Review-Url: https://codereview.chromium.org/2927723003 > Cr-Commit-Position: refs/heads/master@{#478067} > Committed: https://chromium.googlesource.com/chromium/src/+/618fd4f3564ecc43f4f7bff660c22a9dd5fc2309 TBR=dominickn@chromium.org,pkotwicz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2928993004 Cr-Commit-Position: refs/heads/master@{#478154} Committed: https://chromium.googlesource.com/chromium/src/+/7fbcb3b02e0e1e1b3e42c46a4c0c0c1113357fdc

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
jbudorick
Created Revert of [Android Refactor] Merge WebappDataStorage#LAST_USED_UNSET and LAST_USED_INVALID
3 years, 6 months ago (2017-06-09 01:24:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928993004/1
3 years, 6 months ago (2017-06-09 01:25:13 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 01:25:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fbcb3b02e0e1e1b3e42c46a4c0c...

Powered by Google App Engine
This is Rietveld 408576698