Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2928973003: Added --enable-ui-devtools to chrome://flags. (Closed)

Created:
3 years, 6 months ago by bruthig
Modified:
3 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, pfeldman, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, thanhph
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added --enable-ui-devtools to chrome://flags. BUG=678038 Review-Url: https://codereview.chromium.org/2928973003 Cr-Commit-Position: refs/heads/master@{#478258} Committed: https://chromium.googlesource.com/chromium/src/+/eafb0c0e989e157fb1ea1c90fde8157f37cc27c9

Patch Set 1 #

Patch Set 2 : Fixed flag_descriptions.cc formatting. #

Total comments: 3

Patch Set 3 : Updated url in description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M components/ui_devtools/devtools_server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/ui_devtools/switches.h View 1 chunk +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
bruthig
sadrul@, can you PTAL?
3 years, 6 months ago (2017-06-08 18:41:37 UTC) #4
bruthig
https://codereview.chromium.org/2928973003/diff/20001/chrome/browser/flag_descriptions.cc File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2928973003/diff/20001/chrome/browser/flag_descriptions.cc#newcode3209 chrome/browser/flag_descriptions.cc:3209: "chrome-devtools://devtools/bundled/inspector.html?ws=localhost:9223/0"; Should chrome://inspect#other be used here instead?
3 years, 6 months ago (2017-06-08 18:45:01 UTC) #5
sadrul
LGTM! Does this allow remote inspection on chromebook? https://codereview.chromium.org/2928973003/diff/20001/chrome/browser/flag_descriptions.cc File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2928973003/diff/20001/chrome/browser/flag_descriptions.cc#newcode3209 chrome/browser/flag_descriptions.cc:3209: "chrome-devtools://devtools/bundled/inspector.html?ws=localhost:9223/0"; ...
3 years, 6 months ago (2017-06-08 20:38:44 UTC) #6
bruthig
On 2017/06/08 20:38:44, sadrul wrote: > LGTM! > > Does this allow remote inspection on ...
3 years, 6 months ago (2017-06-08 20:57:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928973003/40001
3 years, 6 months ago (2017-06-08 20:57:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/313750)
3 years, 6 months ago (2017-06-08 23:17:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928973003/40001
3 years, 6 months ago (2017-06-09 12:24:26 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 13:12:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eafb0c0e989e157fb1ea1c90fde8...

Powered by Google App Engine
This is Rietveld 408576698