Add client protocol fuzzer test

Add client protocol fuzzer test

BUG=724562
Review-Url: https://codereview.chromium.org/2928863002
Cr-Commit-Position: refs/heads/master@{#478037}
Committed: https://chromium.googlesource.com/chromium/src/+/e96828c915be58a05e07e9e2339536602b334074

[Tom Bergan, 2017-06-07 22:18:07]

tombergan@chromium.org changed reviewers:
+ tombergan@chromium.org

[Tom Bergan, 2017-06-07 22:18:08]

https://codereview.chromium.org/2928863002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/protocol_fuzz.py (right):

https://codereview.chromium.org/2928863002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/protocol_fuzz.py:63: #   foo=bar|empty-image
page_policies=bar|empty-image
Directives should be comma-separated, I think?

https://codereview.chromium.org/2928863002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/protocol_fuzz.py:118: "max_directives": 10,
You can probably shrink this to 3, since most bugs are in a corner-case at the
front, end, or middle.

https://codereview.chromium.org/2928863002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/protocol_fuzz.py:119: "max_directive_values": 10,
Ditto here.

[Robert Ogden, 2017-06-07 23:38:36]

Ryan, Tom please take a look

https://codereview.chromium.org/2928863002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/protocol_fuzz.py (right):

https://codereview.chromium.org/2928863002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/protocol_fuzz.py:63: #   foo=bar|empty-image
page_policies=bar|empty-image
On 2017/06/07 22:18:08, Tom Bergan wrote:
> Directives should be comma-separated, I think?

Done.

https://codereview.chromium.org/2928863002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/protocol_fuzz.py:118: "max_directives": 10,
On 2017/06/07 22:18:08, Tom Bergan wrote:
> You can probably shrink this to 3, since most bugs are in a corner-case at the
> front, end, or middle.

Done.

https://codereview.chromium.org/2928863002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/protocol_fuzz.py:119: "max_directive_values": 10,
On 2017/06/07 22:18:08, Tom Bergan wrote:
> Ditto here.

Done.

[Tom Bergan, 2017-06-08 15:00:18]

lgtm

https://codereview.chromium.org/2928863002/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/protocol_fuzz.py (right):

https://codereview.chromium.org/2928863002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/protocol_fuzz.py:102: "{{RAND_STR(10)}}",
Do we actually need two of these?

https://codereview.chromium.org/2928863002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/protocol_fuzz.py:111: "{{RAND_STR(10)}}",
Ditto here

[Robert Ogden, 2017-06-08 17:17:57]

robertogden@chromium.org changed reviewers:
+ ryansturm@chromium.org

[Robert Ogden, 2017-06-08 17:17:58]

Ryan, I forgot to actually add you to this. oops

https://codereview.chromium.org/2928863002/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/protocol_fuzz.py (right):

https://codereview.chromium.org/2928863002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/protocol_fuzz.py:102: "{{RAND_STR(10)}}",
On 2017/06/08 15:00:18, Tom Bergan wrote:
> Do we actually need two of these?

I was thinking yes so that we get three directives in some tests

https://codereview.chromium.org/2928863002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/protocol_fuzz.py:111: "{{RAND_STR(10)}}",
On 2017/06/08 15:00:18, Tom Bergan wrote:
> Ditto here

Yes, so that there are three random strings in at least one test

[RyanSturm, 2017-06-08 17:31:56]

lgtm

[Robert Ogden, 2017-06-08 18:19:38]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2017-06-08 18:20:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 18:32:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496945978595170,
"parent_rev": "e9038fcca764cce14fd81ed3152abac47a194ba3", "commit_rev":
"e96828c915be58a05e07e9e2339536602b334074"}

[commit-bot: I haz the power, 2017-06-08 18:32:58]

Description was changed from

==========
Add client protocol fuzzer test

BUG=724562
==========

to

==========
Add client protocol fuzzer test

BUG=724562

Review-Url: https://codereview.chromium.org/2928863002
Cr-Commit-Position: refs/heads/master@{#478037}
Committed:
https://chromium.googlesource.com/chromium/src/+/e96828c915be58a05e07e9e23395...
==========

[commit-bot: I haz the power, 2017-06-08 18:33:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e96828c915be58a05e07e9e23395...