Fix header guard and namespace in android_webview

Fix header guard and namespace in android_webview

BUG=716604
TEST=
R=sgurun@chromium.org

Review-Url: https://codereview.chromium.org/2928823004
Cr-Commit-Position: refs/heads/master@{#478394}
Committed: https://chromium.googlesource.com/chromium/src/+/db647e049928d104ea3ba97d43ccbcfd2330ba94

[jinsong.fan, 2017-06-08 18:12:54]

hi sgurn,
I fix a typo in aw_contents_lifecycle_notifier.h
PTAL, thanks.

[sgurun-gerrit only, 2017-06-08 23:32:25]

On 2017/06/08 18:12:54, fanjinsong wrote:
> hi sgurn,
> I fix a typo in aw_contents_lifecycle_notifier.h
> PTAL, thanks.

there are more, for example in input_stream_reader.h. can you go over and fix
them all?

[sgurun-gerrit only, 2017-06-08 23:32:34]

Description was changed from

==========
Fix a typo in AwContentsLifecycleNotifier


BUG=
TEST=
R=sgurun@chromium.org
==========

to

==========
Fix a typo in AwContentsLifecycleNotifier


BUG=
TEST=
R=sgurun@chromium.org
==========

[sgurun-gerrit only, 2017-06-08 23:32:35]

sgurun@chromium.org changed reviewers:
+ ctzsm@chromium.org

[sgurun-gerrit only, 2017-06-08 23:33:14]

On 2017/06/08 23:32:25, sgurun wrote:
> On 2017/06/08 18:12:54, fanjinsong wrote:
> > hi sgurn,
> > I fix a typo in aw_contents_lifecycle_notifier.h
> > PTAL, thanks.
> 
> there are more, for example in input_stream_reader.h. can you go over and fix
> them all?

shimi please guide the CL, and review, I will rubberstamp. thanks

[Shimi Zhang, 2017-06-09 00:17:18]

On 2017/06/08 18:12:54, fanjinsong wrote:
> hi sgurn,
> I fix a typo in aw_contents_lifecycle_notifier.h
> PTAL, thanks.

Hi Jinsong,

Could you fix all of these similar typos?
https://cs.chromium.org/search/?q=ANDROID_WEBVIEW_NATIVE&type=cs

Also please update description and refer to crbug.com/716604 (i.e. BUG=716604)

Thanks!

[jinsong.fan, 2017-06-09 02:01:53]

Description was changed from

==========
Fix a typo in AwContentsLifecycleNotifier


BUG=
TEST=
R=sgurun@chromium.org
==========

to

==========
Fix header guard and namespace in android_webview

BUG=716604
TEST=
R=sgurun@chromium.org
==========

[jinsong.fan, 2017-06-09 02:10:27]

Thanks sgurun.

Hi Shimi,
I find more typos by cpplint in android_webview, new patch and description
upload.

PTAL,
Thanks.

[Shimi Zhang, 2017-06-09 03:52:02]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 03:52:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 03:52:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 03:52:15]

Dry run: The author fanjinsong@sogou-inc.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[Shimi Zhang, 2017-06-09 04:08:41]

On 2017/06/09 03:52:15, commit-bot: I haz the power wrote:
> Dry run: The author mailto:fanjinsong@sogou-inc.com has not signed Google
Contributor
> License Agreement. Please visit https://cla.developers.google.com to sign and
> manage CLA.

Jinsong, I think you need to sign the agreement mentioned above, see more info
about it here https://www.chromium.org/developers/contributing-code (Legal
stuff).

Great work, Thanks!

[jinsong.fan, 2017-06-09 04:15:48]

On 2017/06/09 04:08:41, Shimi Zhang wrote:
> On 2017/06/09 03:52:15, commit-bot: I haz the power wrote:
> > Dry run: The author mailto:fanjinsong@sogou-inc.com has not signed Google
> Contributor
> > License Agreement. Please visit https://cla.developers.google.com to sign
and
> > manage CLA.
> 
> Jinsong, I think you need to sign the agreement mentioned above, see more info
> about it here https://www.chromium.org/developers/contributing-code (Legal
> stuff).
> 
> Great work, Thanks!

Thanks Shimi,
I have done this.

[Shimi Zhang, 2017-06-09 04:19:27]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 04:19:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-06-09 04:20:43]

On 2017/06/09 04:15:48, jinsong.fan wrote:
> On 2017/06/09 04:08:41, Shimi Zhang wrote:
> > On 2017/06/09 03:52:15, commit-bot: I haz the power wrote:
> > > Dry run: The author mailto:fanjinsong@sogou-inc.com has not signed Google
> > Contributor
> > > License Agreement. Please visit https://cla.developers.google.com to sign
> and
> > > manage CLA.
> > 
> > Jinsong, I think you need to sign the agreement mentioned above, see more
info
> > about it here https://www.chromium.org/developers/contributing-code (Legal
> > stuff).
> > 
> > Great work, Thanks!
> 
> Thanks Shimi,
> I have done this.

LGTM

[jinsong.fan, 2017-06-09 04:22:20]

The CQ bit was unchecked by fanjinsong@sogou-inc.com

[jinsong.fan, 2017-06-09 04:22:20]

The CQ bit was checked by fanjinsong@sogou-inc.com

[commit-bot: I haz the power, 2017-06-09 04:22:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 04:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 04:22:34]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[jinsong.fan, 2017-06-09 04:24:09]

The CQ bit was checked by fanjinsong@sogou-inc.com

[commit-bot: I haz the power, 2017-06-09 04:24:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 04:24:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 04:24:25]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Shimi Zhang, 2017-06-09 04:25:53]

On 2017/06/09 04:22:28, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

We need to wait for Selim to give file owner lgtm, also I think you need his
help to commit as well.

[sgurun-gerrit only, 2017-06-09 20:20:37]

On 2017/06/09 04:25:53, Shimi Zhang wrote:
> On 2017/06/09 04:22:28, commit-bot: I haz the power wrote:
> > CQ is trying da patch.
> > 
> > Follow status at:
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> We need to wait for Selim to give file owner lgtm, also I think you need his
> help to commit as well.

lgtm

[sgurun-gerrit only, 2017-06-09 20:20:45]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2017-06-09 20:21:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 20:26:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497039645223460,
"parent_rev": "c0b4d381f2a2ee7c440e3a7cadfb66f4a7ef2bc3", "commit_rev":
"db647e049928d104ea3ba97d43ccbcfd2330ba94"}

[commit-bot: I haz the power, 2017-06-09 20:27:01]

Description was changed from

==========
Fix header guard and namespace in android_webview

BUG=716604
TEST=
R=sgurun@chromium.org
==========

to

==========
Fix header guard and namespace in android_webview

BUG=716604
TEST=
R=sgurun@chromium.org

Review-Url: https://codereview.chromium.org/2928823004
Cr-Commit-Position: refs/heads/master@{#478394}
Committed:
https://chromium.googlesource.com/chromium/src/+/db647e049928d104ea3ba97d43cc...
==========

[commit-bot: I haz the power, 2017-06-09 20:27:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/db647e049928d104ea3ba97d43cc...

[Nico, 2017-06-10 18:01:16]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-06-10 18:01:16]

This patch just deletes two `explicit`s and doesn't do anything related to the
CL description. Did you mix up CL description and patch?

[Nico, 2017-06-10 18:01:59]

Huh, the landed change
(https://chromium.googlesource.com/chromium/src/+/db647e049928d104ea3ba97d43cc...)
is very different from what's uploaded for review here (?)

[Shimi Zhang, 2017-06-10 19:08:01]

On 2017/06/10 18:01:59, Nico (vacation Jun 3-11) wrote:
> Huh, the landed change
>
(https://chromium.googlesource.com/chromium/src/+/db647e049928d104ea3ba97d43cc...)
> is very different from what's uploaded for review here (?)

thakis@, The landed patch is patch 2. We didn't review patch 3.

Jingsong, did you uploaded patch 3 after the CL landed?

[jinsong.fan, 2017-06-10 23:05:34]

On 2017/06/10 19:08:01, Shimi Zhang wrote:
> On 2017/06/10 18:01:59, Nico (vacation Jun 3-11) wrote:
> > Huh, the landed change
> >
>
(https://chromium.googlesource.com/chromium/src/+/db647e049928d104ea3ba97d43cc...)
> > is very different from what's uploaded for review here (?)
> 
> thakis@, The landed patch is patch 2. We didn't review patch 3.
> 
> Jingsong, did you uploaded patch 3 after the CL landed?

Sorry.
I forgot to checkout my local branch to upload an new CL. 
Pls ignore patch 3. I will delete it.
New CL review: https://codereview.chromium.org/2935533002/

Thanks.

[jinsong.fan, 2017-06-10 23:07:03]

Patchset #3 (id:40001) has been deleted