Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2928803006: [Merge to M60] Linux Aura: Use Separate profile key specifically for theme usage (Closed)

Created:
3 years, 6 months ago by Tom Anderson
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge to M60] Linux Aura: Use Separate profile key specifically for theme usage > This CL is a revert to patch set 1 of CL [1]. This is necessary > because window position save/restore for the task manager relies on > the regular profile key being null for the task manager widget. > > [1] https://codereview.chromium.org/2862113002/#ps1 > > BUG=729405 > R=sky@chromium.org > > Review-Url: https://codereview.chromium.org/2923323002 > Cr-Commit-Position: refs/heads/master@{#477872} BUG=729405 TBR=sky@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2928803006 . Cr-Commit-Position: refs/branch-heads/3112@{#286} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/88bf0989418d6a9aee2e4f9de2ae0015181ff081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -29 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/native_widget_factory.cc View 2 chunks +27 lines, -20 lines 0 comments Download
A chrome/browser/ui/views/theme_profile_key.h View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/theme_profile_key.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Tom Anderson
3 years, 6 months ago (2017-06-09 18:03:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88bf0989418d6a9aee2e4f9de2ae0015181ff081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698