Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2928803005: Adding kolos@ and vasilii@ ownerships for password_manager files. (Closed)

Created:
3 years, 6 months ago by dvadym
Modified:
3 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding kolos@ and vasilii@ ownerships for password_manager files. BUG=None Review-Url: https://codereview.chromium.org/2928803005 Cr-Commit-Position: refs/heads/master@{#479335} Committed: https://chromium.googlesource.com/chromium/src/+/93d013d8cd6a86cc366aa46ccf2f1f51361e159b

Patch Set 1 #

Total comments: 2

Patch Set 2 : sort by name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/password_manager/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/autofill/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/common/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
dvadym
Hi Vaclav, could you please review adding Maxim and Vasilii ownership CL? Regards, Vadym
3 years, 6 months ago (2017-06-09 11:56:39 UTC) #3
vabr (Chromium)
Thanks, this is very long overdue! You need an approval from mathp@ or estade@ for ...
3 years, 6 months ago (2017-06-09 12:46:09 UTC) #4
dvadym
https://codereview.chromium.org/2928803005/diff/1/chrome/browser/password_manager/OWNERS File chrome/browser/password_manager/OWNERS (right): https://codereview.chromium.org/2928803005/diff/1/chrome/browser/password_manager/OWNERS#newcode7 chrome/browser/password_manager/OWNERS:7: kolos@chromium.org On 2017/06/09 12:46:09, vabr (Chromium) wrote: > Please ...
3 years, 6 months ago (2017-06-09 13:05:57 UTC) #5
dvadym
estade@chromium.org: Please review changes in chrome/browser/ui/autofill/OWNERS ? This is adding Password Manager team members as ...
3 years, 6 months ago (2017-06-09 13:07:29 UTC) #7
dvadym
estade@ friendly ping
3 years, 6 months ago (2017-06-13 16:18:50 UTC) #8
Evan Stade
sorry, was ooo. lgtm
3 years, 6 months ago (2017-06-13 16:58:47 UTC) #9
dvadym
On 2017/06/13 16:58:47, Evan Stade wrote: > sorry, was ooo. lgtm thanks!
3 years, 6 months ago (2017-06-13 17:03:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928803005/20001
3 years, 6 months ago (2017-06-13 17:03:40 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/287963) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 6 months ago (2017-06-13 17:07:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928803005/20001
3 years, 6 months ago (2017-06-14 09:11:30 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 09:17:09 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93d013d8cd6a86cc366aa46ccf2f...

Powered by Google App Engine
This is Rietveld 408576698