Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2928803003: Swarming UI: Fix issue with negative pending time. (Closed)

Created:
3 years, 6 months ago by ayanaadylova
Modified:
3 years, 6 months ago
Reviewers:
Ryan Tseng, kjlubick
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Swarming UI: Fix issue with negative pending time. Fixed issue with negative pending time. BUG=727944 Review-Url: https://codereview.chromium.org/2928803003 Committed: https://github.com/luci/luci-py/commit/ef20709e111d7ade672d0377b7ba99fc6f742ded

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed duration function. #

Patch Set 3 : Vulcanized files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
ayanaadylova
PTAL
3 years, 6 months ago (2017-06-07 22:00:37 UTC) #2
Ryan Tseng
The CL title should be what is changing in this CL, ie: "Swarming UI: Fix ...
3 years, 6 months ago (2017-06-07 22:06:59 UTC) #3
ayanaadylova
PTAL https://codereview.chromium.org/2928803003/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html File appengine/swarming/ui/res/imp/taskpage/task-page.html (right): https://codereview.chromium.org/2928803003/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html#newcode923 appengine/swarming/ui/res/imp/taskpage/task-page.html:923: if (start.getTime() >= end.getTime()) { On 2017/06/07 22:06:59, ...
3 years, 6 months ago (2017-06-07 22:12:25 UTC) #5
Ryan Tseng
lgtm you might need owners approval before CQ will take the patch.
3 years, 6 months ago (2017-06-07 22:15:09 UTC) #6
kjlubick
See also https://bugs.chromium.org/p/chromium/issues/detail?id=730586 This fix might go better in common/common-behavior.html, _human duration, as it would ...
3 years, 6 months ago (2017-06-08 12:56:38 UTC) #7
kjlubick
Also, don't forget to run `make vulcanize`
3 years, 6 months ago (2017-06-08 12:57:14 UTC) #8
ayanaadylova
On 2017/06/08 12:57:14, kjlubick wrote: > Also, don't forget to run `make vulcanize` I looked ...
3 years, 6 months ago (2017-06-08 17:04:56 UTC) #9
kjlubick
Sure, go ahead and commit this. Post the CL link in the bug I mentioned ...
3 years, 6 months ago (2017-06-09 12:29:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928803003/40001
3 years, 6 months ago (2017-06-09 15:37:29 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 15:41:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/ef20709e111d7ade672d0377b7ba99fc6f742ded

Powered by Google App Engine
This is Rietveld 408576698