Swarming UI: Fix issue with negative pending time.

Swarming UI: Fix issue with negative pending time.

Fixed issue with negative pending time.

BUG=727944
Review-Url: https://codereview.chromium.org/2928803003
Committed: https://github.com/luci/luci-py/commit/ef20709e111d7ade672d0377b7ba99fc6f742ded

[ayanaadylova, 2017-06-07 22:00:36]

ayanaadylova@google.com changed reviewers:
+ hinoka@google.com, kjlubick@google.com

[ayanaadylova, 2017-06-07 22:00:37]

PTAL

[Ryan Tseng, 2017-06-07 22:06:59]

The CL title should be what is changing in this CL, ie: "Swarming UI: Fix issue
with negative pending time"

https://codereview.chromium.org/2928803003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/taskpage/task-page.html (right):

https://codereview.chromium.org/2928803003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/taskpage/task-page.html:923: if (start.getTime()
>= end.getTime()) {
to avoid calling getTime() this many times, i'd probably do

var dur = end.getTime() - start.getTime()
if (dur < 0) dur = 0;
return dur;

[ayanaadylova, 2017-06-07 22:11:41]

Description was changed from

==========
Swarming UI: Added piechart for timing information.

Fixed issue with negative pending time.

BUG=727944
==========

to

==========
Swarming UI: Fix issue with negative pending time.

Fixed issue with negative pending time.

BUG=727944
==========

[ayanaadylova, 2017-06-07 22:12:25]

PTAL

https://codereview.chromium.org/2928803003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/taskpage/task-page.html (right):

https://codereview.chromium.org/2928803003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/taskpage/task-page.html:923: if (start.getTime()
>= end.getTime()) {
On 2017/06/07 22:06:59, Ryan Tseng wrote:
> to avoid calling getTime() this many times, i'd probably do
> 
> var dur = end.getTime() - start.getTime()
> if (dur < 0) dur = 0;
> return dur;

Done.

[Ryan Tseng, 2017-06-07 22:15:09]

lgtm

you might need owners approval before CQ will take the patch.

[kjlubick, 2017-06-08 12:56:38]

See also https://bugs.chromium.org/p/chromium/issues/detail?id=730586

This fix might go better in common/common-behavior.html, _human duration, as it
would fix it in multiple places.

[kjlubick, 2017-06-08 12:57:14]

Also, don't forget to run `make vulcanize`

[ayanaadylova, 2017-06-08 17:04:56]

On 2017/06/08 12:57:14, kjlubick wrote:
> Also, don't forget to run `make vulcanize`

I looked at the bug you included in the previous message, but it seems like it
is already assigned. 
I also saw the comment of Marc-Antoine Ruel in the previous pie chart CL where
he suggested to use bar chart instead. I talked about that with one of my hosts,
Sergey Berezin, and he said since it's my first bug that I needed to fix it is
fine to leave it and concentrate more on the project. However, if you think it
would be better to change it, I will be more than happy to do that.

PTAL

[kjlubick, 2017-06-09 12:29:20]

Sure, go ahead and commit this.  Post the CL link in the bug I mentioned so I
remember to combine the fixes when I'm back next week.

lgtm

[ayanaadylova, 2017-06-09 15:37:24]

The CQ bit was checked by ayanaadylova@google.com

[ayanaadylova, 2017-06-09 15:37:24]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@google.com
Link to the patchset: https://codereview.chromium.org/2928803003/#ps40001
(title: "Vulcanized files.")

[commit-bot: I haz the power, 2017-06-09 15:37:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 15:41:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497022644051040,
"parent_rev": "d6d033b305753e75d4b4d80f9de27198f4046eff", "commit_rev":
"ef20709e111d7ade672d0377b7ba99fc6f742ded"}

[commit-bot: I haz the power, 2017-06-09 15:41:22]

Description was changed from

==========
Swarming UI: Fix issue with negative pending time.

Fixed issue with negative pending time.

BUG=727944
==========

to

==========
Swarming UI: Fix issue with negative pending time.

Fixed issue with negative pending time.

BUG=727944

Review-Url: https://codereview.chromium.org/2928803003
Committed:
https://github.com/luci/luci-py/commit/ef20709e111d7ade672d0377b7ba99fc6f742ded
==========

[commit-bot: I haz the power, 2017-06-09 15:41:23]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/ef20709e111d7ade672d0377b7ba99fc6f742ded