Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2928793002: Use the substr API correctly in FullHashToHashPrefix. (Closed)

Created:
3 years, 6 months ago by Jialiu Lin
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Use the substr API correctly in FullHashToHashPrefix. This code path is only used for permissions blacklists so the rest of PVer4 launch can progress as-is. Bug: 729809 Change-Id: Iec6af24fadae59c6e16c109c0990bc6159575e60 Reviewed-on: https://chromium-review.googlesource.com/524892 Reviewed-by: Jialiu Lin <jialiul@chromium.org>; Reviewed-by: Nathan Parker <nparker@chromium.org>; Commit-Queue: Varun Khaneja <vakh@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#477292} Review-Url: https://codereview.chromium.org/2928793002 . Cr-Commit-Position: refs/branch-heads/3112@{#228} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/203a0320bd08e0a1832c2692309783de3aa66aab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M components/safe_browsing_db/v4_protocol_manager_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jialiu Lin
3 years, 6 months ago (2017-06-07 19:04:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
203a0320bd08e0a1832c2692309783de3aa66aab.

Powered by Google App Engine
This is Rietveld 408576698