Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 2928783002: Handling disappear or new sections in after.size file (Closed)

Created:
3 years, 6 months ago by bshe
Modified:
3 years, 6 months ago
Reviewers:
agrieve
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Handling disappear or new sections in after.size file BUG=730717 Review-Url: https://codereview.chromium.org/2928783002 Cr-Commit-Position: refs/heads/master@{#478011} Committed: https://chromium.googlesource.com/chromium/src/+/a7624780cbd20f45ccd6718905838ec67bf79e8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/binary_size/libsupersize/diff.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
bshe
Hi Andrew. Just upload your fix for the error that I encountered. Thanks
3 years, 6 months ago (2017-06-07 18:50:25 UTC) #2
agrieve
On 2017/06/07 18:50:25, bshe(OOO) wrote: > Hi Andrew. > > Just upload your fix for ...
3 years, 6 months ago (2017-06-07 18:58:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928783002/1
3 years, 6 months ago (2017-06-07 19:03:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/444916)
3 years, 6 months ago (2017-06-07 19:18:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928783002/1
3 years, 6 months ago (2017-06-08 17:22:15 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 17:26:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7624780cbd20f45ccd671890583...

Powered by Google App Engine
This is Rietveld 408576698