Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2928733004:
CryptAuth: Improve logging around device syncing to display a human-readable device name. (Closed)
|
Created:
3 years, 6 months ago by Ryan Hansberry Modified:
3 years, 6 months ago Reviewers:
Kyle Horimoto CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionCryptAuth: Improve logging around device syncing to display a human-readable device name.
BUG=
Review-Url: https://codereview.chromium.org/2928733004
Cr-Commit-Position: refs/heads/master@{#478356}
Committed: https://chromium.googlesource.com/chromium/src/+/6d116f3f194f67d1c7f318218861e308bf1cf769
Patch Set 1 #
Total comments: 2
Patch Set 2 : khorimoto@ comment. #Patch Set 3 : Fix typo. #Messages
Total messages: 20 (11 generated)
Description was changed from ========== CryptAuth: Improve logging around device syncing to display a human-readable device name. BUG= ========== to ========== CryptAuth: Improve logging around device syncing to display a human-readable device name. BUG= ==========
hansberry@chromium.org changed reviewers: + khorimoto@chromium.org
lgtm https://codereview.chromium.org/2928733004/diff/1/components/cryptauth/crypta... File components/cryptauth/cryptauth_device_manager.cc (right): https://codereview.chromium.org/2928733004/diff/1/components/cryptauth/crypta... components/cryptauth/cryptauth_device_manager.cc:423: PA_LOG(INFO) << "Devices were successfully synced."; nit: Only print if !responses.devices().empty().
https://codereview.chromium.org/2928733004/diff/1/components/cryptauth/crypta... File components/cryptauth/cryptauth_device_manager.cc (right): https://codereview.chromium.org/2928733004/diff/1/components/cryptauth/crypta... components/cryptauth/cryptauth_device_manager.cc:423: PA_LOG(INFO) << "Devices were successfully synced."; On 2017/06/08 20:43:03, Kyle Horimoto wrote: > nit: Only print if !responses.devices().empty(). Done.
The CQ bit was checked by hansberry@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from khorimoto@chromium.org Link to the patchset: https://codereview.chromium.org/2928733004/#ps20001 (title: "khorimoto@ comment.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hansberry@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from khorimoto@chromium.org Link to the patchset: https://codereview.chromium.org/2928733004/#ps40001 (title: "Fix typo.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by hansberry@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497030773687830,
"parent_rev": "7d3b44d7d03614dd15fda5e81df050b0e618ad2b", "commit_rev":
"6d116f3f194f67d1c7f318218861e308bf1cf769"}
Message was sent while issue was closed.
Description was changed from ========== CryptAuth: Improve logging around device syncing to display a human-readable device name. BUG= ========== to ========== CryptAuth: Improve logging around device syncing to display a human-readable device name. BUG= Review-Url: https://codereview.chromium.org/2928733004 Cr-Commit-Position: refs/heads/master@{#478356} Committed: https://chromium.googlesource.com/chromium/src/+/6d116f3f194f67d1c7f318218861... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6d116f3f194f67d1c7f318218861... |
