Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2928723003: Support a short-hand way to create linked edit groups (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
Also cleans up a warning from an unused import.
3 years, 6 months ago (2017-06-07 15:15:33 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2928723003/diff/1/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart File pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart (right): https://codereview.chromium.org/2928723003/diff/1/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart#newcode159 pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart:159: if (suggestions != null && kind != null) ...
3 years, 6 months ago (2017-06-07 15:39:11 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2928723003/diff/1/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart File pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart (right): https://codereview.chromium.org/2928723003/diff/1/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart#newcode159 pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart:159: if (suggestions != null && kind != null) { ...
3 years, 6 months ago (2017-06-07 16:07:19 UTC) #4
Brian Wilkerson
3 years, 6 months ago (2017-06-07 16:07:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8919b82375979b41e4a2bbe065c4203c9139377 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698