Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart

Issue 2928723003: Support a short-hand way to create linked edit groups (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
diff --git a/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart b/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
index fd05cca29dc50ccec8456521162f8a6a766f93ee..700658bf180f48501162985786173f3934cff61b 100644
--- a/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
+++ b/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
@@ -107,9 +107,7 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
if (nameGroupName == null) {
write(name);
} else {
- addLinkedEdit(nameGroupName, (LinkedEditBuilder builder) {
- write(name);
- });
+ addSimpleLinkedEdit(nameGroupName, name);
}
if (superclass != null) {
write(' extends ');
@@ -145,9 +143,7 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
if (constructorNameGroupName == null) {
write(constructorName.name);
} else {
- addLinkedEdit(constructorNameGroupName, (LinkedEditBuilder builder) {
- write(constructorName.name);
- });
+ addSimpleLinkedEdit(constructorNameGroupName, constructorName.name);
}
}
write('(');
@@ -193,9 +189,7 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
}
write(' ');
if (nameGroupName != null) {
- addLinkedEdit(nameGroupName, (LinkedEditBuilder builder) {
- write(name);
- });
+ addSimpleLinkedEdit(nameGroupName, name);
} else {
write(name);
}
@@ -224,9 +218,7 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
}
}
if (nameGroupName != null) {
- addLinkedEdit(nameGroupName, (LinkedEditBuilder builder) {
- write(name);
- });
+ addSimpleLinkedEdit(nameGroupName, name);
} else {
write(name);
}
@@ -266,9 +258,7 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
write(Keyword.GET.lexeme);
write(' ');
if (nameGroupName != null) {
- addLinkedEdit(nameGroupName, (LinkedEditBuilder builder) {
- write(name);
- });
+ addSimpleLinkedEdit(nameGroupName, name);
} else {
write(name);
}
@@ -307,9 +297,7 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
}
write(' ');
if (nameGroupName != null) {
- addLinkedEdit(nameGroupName, (LinkedEditBuilder builder) {
- write(name);
- });
+ addSimpleLinkedEdit(nameGroupName, name);
} else {
write(name);
}
@@ -395,10 +383,8 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
_getParameterNameSuggestions(usedNames, type, argument, index);
String favorite = suggestions[0];
usedNames.add(favorite);
- addLinkedEdit('PARAM$index', (LinkedEditBuilder builder) {
- write(favorite);
- builder.addSuggestions(LinkedEditSuggestionKind.PARAMETER, suggestions);
- });
+ addSimpleLinkedEdit('PARAM$index', favorite,
+ kind: LinkedEditSuggestionKind.PARAMETER, suggestions: suggestions);
}
}

Powered by Google App Engine
This is Rietveld 408576698