Ensure only one live search engine promo.

Ensure only one live search engine promo.

BUG=729106
Review-Url: https://codereview.chromium.org/2928653003
Cr-Commit-Position: refs/heads/master@{#478734}
Committed: https://chromium.googlesource.com/chromium/src/+/9010f6cbfa29ee8d337d0d236dd07ac2a823fa27

[Ted C, 2017-06-07 18:22:01]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ted C, 2017-06-07 18:22:02]

PTAL

[gone, 2017-06-09 17:26:56]

lgtm

https://codereview.chromium.org/2928653003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialogTest.java
(right):

https://codereview.chromium.org/2928653003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialogTest.java:44:
* Integration tests for the default search engine promo dialog.
{@link DefaultSearchEnginePromoDialog}

https://codereview.chromium.org/2928653003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialogTest.java:120:
private <T extends Activity> T startActivity(Class<T> clazz) throws Exception {
We should probably just yank this function out and put it somewhere.  Aside from
the custom animation, it's pretty much the same in the various places I've seen
it.  Maybe MultiActivityTestCommon or MultiActivityTestRule?

[Ted C, 2017-06-09 21:31:52]

Updated to move to ActivityUtils for activity starting.  Updated the test a bit
as well as destroy wasn't reliable but isFinishing was.

https://codereview.chromium.org/2928653003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialogTest.java
(right):

https://codereview.chromium.org/2928653003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialogTest.java:44:
* Integration tests for the default search engine promo dialog.
On 2017/06/09 17:26:56, dfalcantara wrote:
> {@link DefaultSearchEnginePromoDialog}

Done.

[gone, 2017-06-09 21:33:57]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-06-09 21:33:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2928653003/#ps40001
(title: "Move to ActivityUtils")

[commit-bot: I haz the power, 2017-06-09 21:34:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 22:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 22:28:57]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ted C, 2017-06-09 22:48:48]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-06-09 22:49:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 00:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 00:46:56]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Ted C, 2017-06-12 18:03:57]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-06-12 18:03:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2928653003/#ps60001
(title: "Fix findbugs")

[commit-bot: I haz the power, 2017-06-12 18:04:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:04:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497290637050760,
"parent_rev": "ac6ccd29b4eaa1e056c0cd0656e2fad8aa624d42", "commit_rev":
"9010f6cbfa29ee8d337d0d236dd07ac2a823fa27"}

[commit-bot: I haz the power, 2017-06-12 20:04:34]

Description was changed from

==========
Ensure only one live search engine promo.

BUG=729106
==========

to

==========
Ensure only one live search engine promo.

BUG=729106

Review-Url: https://codereview.chromium.org/2928653003
Cr-Commit-Position: refs/heads/master@{#478734}
Committed:
https://chromium.googlesource.com/chromium/src/+/9010f6cbfa29ee8d337d0d236dd0...
==========

[commit-bot: I haz the power, 2017-06-12 20:04:35]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9010f6cbfa29ee8d337d0d236dd0...