Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2928643003: Propagate auto-resize viewport values to OOPIF processes (Closed)

Created:
3 years, 6 months ago by kenrb
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Propagate auto-resize viewport values to OOPIF processes RenderWidgetHostViewChildFrame currently gets its visible viewport size from the top-level RenderWidgetHostView, which typically comes from the platform window. However, when the top-level frame has auto-resize enabled, internally it sets its own visible viewport, and this information not available to OOPIF children. This causes issues in particular for extension popups which have window sizes of (0, 0) and rely on auto-resize to modify the viewport in Blink. This patch causes the WebContents to store the auto-resize value reported by the top-level frame and make it available to OOPIF RenderWidgetHostViews. They, in turn, allow an auto-resize size to override the windows size when determining their visible viewport. BUG=726743 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2914013004 Cr-Original-Commit-Position: refs/heads/master@{#476772} Review-Url: https://codereview.chromium.org/2928643003 . Cr-Commit-Position: refs/branch-heads/3112@{#202} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/aac33a6085f198ec79b3ea1c293392a3c0d2098f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_browsertest.cc View 3 chunks +41 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kenrb
3 years, 6 months ago (2017-06-06 20:11:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aac33a6085f198ec79b3ea1c293392a3c0d2098f.

Powered by Google App Engine
This is Rietveld 408576698