Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2928623002:
Work around Xcode 9 debug actool message. (Closed)
|
Created:
3 years, 6 months ago by justincohen Modified:
3 years, 6 months ago CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionWork around Xcode 9 debug actool message.
Xcode 9's beta introduced a CoreUI(DEBUG) message followed by a detail message
that can be ignored. Presumably this will be removed once Xcode 9 GMs.
BUG=730054
Review-Url: https://codereview.chromium.org/2928623002
Cr-Commit-Position: refs/heads/master@{#477535}
Committed: https://chromium.googlesource.com/chromium/src/+/44098da69108f7a5525edbfb307cf73c9902de66
Patch Set 1 #
Total comments: 6
Patch Set 2 : Scope more tightly #Messages
Total messages: 22 (10 generated)
justincohen@chromium.org changed reviewers: + sdefresne@chromium.org
ptal
lgtm to unblock you but please address comments :-P https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... File build/toolchain/mac/compile_xcassets.py (right): https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... build/toolchain/mac/compile_xcassets.py:65: skip_next = False It looks like the next line is 2017-06-06 10:42:25.690 IBCocoaTouchImageCatalogTool[4246:24111] RPC shutdown with error: Error Domain=IBMessageChannelErrorDomain Code=4 "Failed to communicate with Interface Builder" UserInfo={NSLocalizedDescription=Failed to communicate with Interface Builder, NSLocalizedFailureReason=The agent crashed} which look like the issue we had when using different versions of actool. Can we add a separate check for that line, something like the following: if line.contains("Error Domain=IBMessageChannelErrorDomain Code=4"): continue And update the comment (I think this is independent of Xcode 9 GM). https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... build/toolchain/mac/compile_xcassets.py:76: print line I think this "print line" is debug and need to be removed.
https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... File build/toolchain/mac/compile_xcassets.py (right): https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... build/toolchain/mac/compile_xcassets.py:65: skip_next = False On 2017/06/06 16:49:02, sdefresne wrote: > It looks like the next line is > > 2017-06-06 10:42:25.690 IBCocoaTouchImageCatalogTool[4246:24111] RPC shutdown > with error: Error Domain=IBMessageChannelErrorDomain Code=4 "Failed to > communicate with Interface Builder" UserInfo={NSLocalizedDescription=Failed to > communicate with Interface Builder, NSLocalizedFailureReason=The agent crashed} > > which look like the issue we had when using different versions of actool. > > Can we add a separate check for that line, something like the following: > > if line.contains("Error Domain=IBMessageChannelErrorDomain Code=4"): > continue > > And update the comment (I think this is independent of Xcode 9 GM). Are you sure we want to do this? I have no idea if IBMessageChannelErrorDomain/4 is something we can always ignore, or just ignore after a Debug message? If you do, then I'll remove all the skip_next logic. When we had the error before, did we still have com.apple.actool.compilation-results? I wonder if we should just make sure com.apple.actool.compilation-results exists and ignore everything else? https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... build/toolchain/mac/compile_xcassets.py:76: print line On 2017/06/06 16:49:02, sdefresne wrote: > I think this "print line" is debug and need to be removed. oops, thanks!
rohitrao@chromium.org changed reviewers: + rohitrao@chromium.org
https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... File build/toolchain/mac/compile_xcassets.py (right): https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... build/toolchain/mac/compile_xcassets.py:65: skip_next = False On 2017/06/06 17:26:00, justincohen wrote: > On 2017/06/06 16:49:02, sdefresne wrote: > > It looks like the next line is > > > > 2017-06-06 10:42:25.690 IBCocoaTouchImageCatalogTool[4246:24111] RPC shutdown > > with error: Error Domain=IBMessageChannelErrorDomain Code=4 "Failed to > > communicate with Interface Builder" UserInfo={NSLocalizedDescription=Failed to > > communicate with Interface Builder, NSLocalizedFailureReason=The agent > crashed} > > > > which look like the issue we had when using different versions of actool. > > > > Can we add a separate check for that line, something like the following: > > > > if line.contains("Error Domain=IBMessageChannelErrorDomain Code=4"): > > continue > > > > And update the comment (I think this is independent of Xcode 9 GM). > > Are you sure we want to do this? I have no idea if > IBMessageChannelErrorDomain/4 is something we can always ignore, or just ignore > after a Debug message? > > If you do, then I'll remove all the skip_next logic. > > When we had the error before, did we still have > com.apple.actool.compilation-results? I wonder if we should just make sure > com.apple.actool.compilation-results exists and ignore everything else? I'd like to scope this as tightly to the actual error message we're seeing as possible. We may have to ignore more things in the future, but at least we'll get loud errors when something unexpected pops up.
https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... File build/toolchain/mac/compile_xcassets.py (right): https://codereview.chromium.org/2928623002/diff/1/build/toolchain/mac/compile... build/toolchain/mac/compile_xcassets.py:65: skip_next = False On 2017/06/06 18:09:46, rohitrao (ping after 24h) wrote: > On 2017/06/06 17:26:00, justincohen wrote: > > On 2017/06/06 16:49:02, sdefresne wrote: > > > It looks like the next line is > > > > > > 2017-06-06 10:42:25.690 IBCocoaTouchImageCatalogTool[4246:24111] RPC > shutdown > > > with error: Error Domain=IBMessageChannelErrorDomain Code=4 "Failed to > > > communicate with Interface Builder" UserInfo={NSLocalizedDescription=Failed > to > > > communicate with Interface Builder, NSLocalizedFailureReason=The agent > > crashed} > > > > > > which look like the issue we had when using different versions of actool. > > > > > > Can we add a separate check for that line, something like the following: > > > > > > if line.contains("Error Domain=IBMessageChannelErrorDomain Code=4"): > > > continue > > > > > > And update the comment (I think this is independent of Xcode 9 GM). > > > > Are you sure we want to do this? I have no idea if > > IBMessageChannelErrorDomain/4 is something we can always ignore, or just > ignore > > after a Debug message? > > > > If you do, then I'll remove all the skip_next logic. > > > > When we had the error before, did we still have > > com.apple.actool.compilation-results? I wonder if we should just make sure > > com.apple.actool.compilation-results exists and ignore everything else? > > I'd like to scope this as tightly to the actual error message we're seeing as > possible. We may have to ignore more things in the future, but at least we'll > get loud errors when something unexpected pops up. Done.
The CQ bit was checked by justincohen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2928623002/#ps20001 (title: "Scope more tightly")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
justincohen@chromium.org changed reviewers: + dpranke@google.com
ptal dpranke@ for OWNERS
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496803084650580,
"parent_rev": "c06dfa08f681ef8052a1aed514db88a56499a5f5", "commit_rev":
"44098da69108f7a5525edbfb307cf73c9902de66"}
Message was sent while issue was closed.
Description was changed from ========== Work around Xcode 9 debug actool message. Xcode 9's beta introduced a CoreUI(DEBUG) message followed by a detail message that can be ignored. Presumably this will be removed once Xcode 9 GMs. BUG=730054 ========== to ========== Work around Xcode 9 debug actool message. Xcode 9's beta introduced a CoreUI(DEBUG) message followed by a detail message that can be ignored. Presumably this will be removed once Xcode 9 GMs. BUG=730054 Review-Url: https://codereview.chromium.org/2928623002 Cr-Commit-Position: refs/heads/master@{#477535} Committed: https://chromium.googlesource.com/chromium/src/+/44098da69108f7a5525edbfb307c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/44098da69108f7a5525edbfb307c... |
