Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2928483006: Fix CompositorSurfaceManager synthetic surfaceCreated arg order. (Closed)

Created:
3 years, 6 months ago by liberato (no reviews please)
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Fix CompositorSurfaceManager synthetic surfaceCreated arg order. [Merge to M60] When sending a synthetic surfaceChanged to the client, CSM swapped the order of the width, height pair with the surface format. As a result, the compositor got the wrong value for all of them. This CL also updates the test to check for this case, since it was using anyInt() in the matchers previously. BUG=728790 TEST=CompositorSurfaceManagerTest Review-Url: https://codereview.chromium.org/2916153002 Review-Url: https://codereview.chromium.org/2928483006 . Cr-Commit-Position: refs/branch-heads/3112@{#233} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/54644fd3cf8319f81869a3a557922b37d6ff1f27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java View 6 chunks +34 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
liberato (no reviews please)
3 years, 6 months ago (2017-06-07 20:56:20 UTC) #1
Description was changed from

==========
Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

[Merge to M60]

When sending a synthetic surfaceChanged to the client, CSM swapped
the order of the width, height pair with the surface format.  As a
result, the compositor got the wrong value for all of them.

This CL also updates the test to check for this case, since it was
using anyInt() in the matchers previously.

BUG=728790
TEST=CompositorSurfaceManagerTest

Review-Url: https://codereview.chromium.org/2916153002
(cherry picked from commit 4b1deb98719a901d1050f200e64d9164d1b2912b)
==========

to

==========
Fix CompositorSurfaceManager synthetic surfaceCreated arg order.

[Merge to M60]

When sending a synthetic surfaceChanged to the client, CSM swapped
the order of the width, height pair with the surface format.  As a
result, the compositor got the wrong value for all of them.

This CL also updates the test to check for this case, since it was
using anyInt() in the matchers previously.

BUG=728790
TEST=CompositorSurfaceManagerTest

Review-Url: https://codereview.chromium.org/2916153002
Review-Url: https://codereview.chromium.org/2928483006 .
Cr-Commit-Position: refs/branch-heads/3112@{#233}
Cr-Branched-From:
b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed:
https://chromium.googlesource.com/chromium/src/+/54644fd3cf8319f81869a3a55792...
==========

Powered by Google App Engine
This is Rietveld 408576698