Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2928433004:
Add thread-checker for public methods of message center (Closed)
DescriptionAdd thread-checker for public methods of message center
These checks are working only if DCHECK is enabled.
BUG=none
Review-Url: https://codereview.chromium.org/2928433004
Cr-Commit-Position: refs/heads/master@{#479985}
Committed: https://chromium.googlesource.com/chromium/src/+/89174ae3149c9b72dea9f97dc49e9d223fb6936d
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== wip BUG= ========== to ========== Add thread-checker for public methods of message center BUG=none ==========
yoshiki@chromium.org changed reviewers: + fukino@chromium.org
Description was changed from ========== Add thread-checker for public methods of message center BUG=none ========== to ========== Add thread-checker for public methods of message center These checks are working only on debug mode. BUG=none ==========
Description was changed from ========== Add thread-checker for public methods of message center These checks are working only on debug mode. BUG=none ========== to ========== Add thread-checker for public methods of message center These checks are working only is DCHECK is enabled. BUG=none ==========
Fukino-san, PTAL. Thanks.
lgtm nit for CL description: s/is/when/ ?
Description was changed from ========== Add thread-checker for public methods of message center These checks are working only is DCHECK is enabled. BUG=none ========== to ========== Add thread-checker for public methods of message center These checks are working only if DCHECK is enabled. BUG=none ==========
Thanks. Fixed the description.
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497595722899980, "parent_rev":
"5eb4cc9529a8a099a5f4b99fab6ad94f80bd9a14", "commit_rev":
"89174ae3149c9b72dea9f97dc49e9d223fb6936d"}
Message was sent while issue was closed.
Description was changed from ========== Add thread-checker for public methods of message center These checks are working only if DCHECK is enabled. BUG=none ========== to ========== Add thread-checker for public methods of message center These checks are working only if DCHECK is enabled. BUG=none Review-Url: https://codereview.chromium.org/2928433004 Cr-Commit-Position: refs/heads/master@{#479985} Committed: https://chromium.googlesource.com/chromium/src/+/89174ae3149c9b72dea9f97dc49e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/89174ae3149c9b72dea9f97dc49e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
