Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2928423003: Fix ChromeOS build. (Closed)

Created:
3 years, 6 months ago by Jamie
Modified:
3 years, 6 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeOS build. BUG=731711 Review-Url: https://codereview.chromium.org/2928423003 Cr-Commit-Position: refs/heads/master@{#478824} Committed: https://chromium.googlesource.com/chromium/src/+/759ec5f572a9f9b9ad8ba2262c9fbefb321df0fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M remoting/host/setup/me2me_native_messaging_host_main.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jamie
ptal
3 years, 6 months ago (2017-06-12 22:35:06 UTC) #2
Sergey Ulanov
LGTM I don't think if we need that target enabled on ChromeOS, but ifdef'ing that ...
3 years, 6 months ago (2017-06-12 23:11:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928423003/1
3 years, 6 months ago (2017-06-12 23:27:21 UTC) #5
Jamie
On 2017/06/12 23:11:13, Sergey Ulanov wrote: > LGTM > I don't think if we need ...
3 years, 6 months ago (2017-06-12 23:27:26 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 23:49:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/759ec5f572a9f9b9ad8ba2262c9f...

Powered by Google App Engine
This is Rietveld 408576698