Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2928423002: [ObjC ARC] Converts ios/chrome/browser/snapshots:unit_tests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin, justincohen
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/snapshots:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2928423002 Cr-Commit-Position: refs/heads/master@{#478981} Committed: https://chromium.googlesource.com/chromium/src/+/20c4506a8eeac8b679a8cd61cfb21e38c6a8348c

Patch Set 1 #

Patch Set 2 : Remove spurious files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -33 lines) Patch
M ios/chrome/browser/snapshots/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/snapshots/lru_cache_unittest.mm View 2 chunks +10 lines, -11 lines 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache_unittest.mm View 10 chunks +22 lines, -22 lines 0 comments Download
M ios/chrome/browser/snapshots/snapshots_util_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
marq (ping after 24h)
Remove spurious files.
3 years, 6 months ago (2017-06-12 18:13:09 UTC) #5
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 20:08:12 UTC) #11
stkhapugin
lgtm
3 years, 6 months ago (2017-06-13 12:07:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928423002/20001
3 years, 6 months ago (2017-06-13 12:21:31 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 12:26:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/20c4506a8eeac8b679a8cd61cfb2...

Powered by Google App Engine
This is Rietveld 408576698