Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2928353002: Declare missing fields of DropData in IPC_STRUCT_TRAITS

Created:
3 years, 6 months ago by Surendra
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Declare missing fields of DropData in IPC_STRUCT_TRAITS "did_originate_from_renderer" and "file_mime_types" fields in DropData are added in IPC_STRUCT_TRAITS which were previously missed from declaration. BUG=708366 Signed-off-by: bollavaram.s <bollavaram.s@samsung.com>;

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/drag_traits.h View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 16 (10 generated)
Surendra
3 years, 6 months ago (2017-06-12 11:00:54 UTC) #9
Surendra
3 years, 6 months ago (2017-06-14 04:38:29 UTC) #11
Srirama
Looks fine to me.
3 years, 6 months ago (2017-06-14 13:52:51 UTC) #12
David Trainor- moved to gerrit
+dcheng@ who had some good ideas on the bug. I think we rename this to ...
3 years, 6 months ago (2017-06-15 17:48:16 UTC) #14
David Trainor- moved to gerrit
On 2017/06/15 17:48:16, David Trainor-ping after 12h wrote: > +dcheng@ who had some good ideas ...
3 years, 6 months ago (2017-06-15 17:49:45 UTC) #15
dcheng
3 years, 6 months ago (2017-06-15 19:33:52 UTC) #16
On 2017/06/15 17:49:45, David Trainor-ping after 12h wrote:
> On 2017/06/15 17:48:16, David Trainor-ping after 12h wrote:
> > +dcheng@ who had some good ideas on the bug.  I think we rename this to
> > drag_traits_messages.h so that it gets defaulted to OWNERS:
> > file://ipc/SECURITY_OWNERS.
> 
> Ah sorry that was a bad suggestion.  Instead add the this traits file to
> content/common/OWNERS like the other *traits files.  Sorry for the confusion. 
> dcheng@ let me know if this updated advice is incorrect.  Thanks!

Renaming to drag_param_traits.h seems reasonable to me (and matches the
convention for legacy IPC).

https://codereview.chromium.org/2928353002/diff/1/content/common/drag_traits.h
File content/common/drag_traits.h (right):

https://codereview.chromium.org/2928353002/diff/1/content/common/drag_traits....
content/common/drag_traits.h:27:
IPC_STRUCT_TRAITS_MEMBER(did_originate_from_renderer)
I'm not sure if we should plumb this one through. It's used only on the browser
side for checks, and we wouldn't want to trust this bit when it comes from the
renderer anyway.

https://codereview.chromium.org/2928353002/diff/1/content/common/drag_traits....
content/common/drag_traits.h:33: IPC_STRUCT_TRAITS_MEMBER(file_mime_types)
Similarly it doesn't seem like this is actually used except for generating
DropData::Metadata. So maybe it doesn't belong in drop data?

Powered by Google App Engine
This is Rietveld 408576698