Declare missing fields of DropData in IPC_STRUCT_TRAITS

Declare missing fields of DropData in IPC_STRUCT_TRAITS

"did_originate_from_renderer" and "file_mime_types" fields in DropData
are added in IPC_STRUCT_TRAITS which were previously missed from
declaration.

BUG=708366
Signed-off-by: bollavaram.s <bollavaram.s@samsung.com>;

[Surendra, 2017-06-12 09:29:14]

Description was changed from

==========
Declare missing fields of DropData in IPC_STRUCT_TRAITS

"did_originate_from_renderer" and "file_mime_types" fields in DropData are added
in IPC_STRUCT_TRAITS which were previously missed from declaration.

BUG=708366

Signed-off-by: bollavaram.s <bollavaram.s@samsung.com>
==========

to

==========
Declare missing fields of DropData in IPC_STRUCT_TRAITS

"did_originate_from_renderer" and "file_mime_types" fields in DropData
are added in IPC_STRUCT_TRAITS which were previously missed from declaration.

BUG=708366

Signed-off-by: bollavaram.s <bollavaram.s@samsung.com>
==========

[Surendra, 2017-06-12 09:29:14]

bollavaram.s@samsung.com changed reviewers:
+ sataya.m@samsung.com, xingliu@chromium.org

[Surendra, 2017-06-12 09:29:40]

Description was changed from

==========
Declare missing fields of DropData in IPC_STRUCT_TRAITS

"did_originate_from_renderer" and "file_mime_types" fields in DropData
are added in IPC_STRUCT_TRAITS which were previously missed from declaration.

BUG=708366

Signed-off-by: bollavaram.s <bollavaram.s@samsung.com>
==========

to

==========
Declare missing fields of DropData in IPC_STRUCT_TRAITS

"did_originate_from_renderer" and "file_mime_types" fields in DropData
are added in IPC_STRUCT_TRAITS which were previously missed from
declaration.

BUG=708366

Signed-off-by: bollavaram.s <bollavaram.s@samsung.com>
==========

[Surendra, 2017-06-12 10:09:12]

The CQ bit was checked by bollavaram.s@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 10:09:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 10:09:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 10:09:24]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Surendra, 2017-06-12 11:00:07]

bollavaram.s@samsung.com changed reviewers:
+ jln@chromium.org

[Surendra, 2017-06-14 04:38:06]

bollavaram.s@samsung.com changed reviewers:
+ sadrul@chromium.org, srirama.m@samsung.com

[Srirama, 2017-06-14 13:52:51]

Looks fine to me.

[David Trainor- moved to gerrit, 2017-06-15 17:48:15]

dtrainor@chromium.org changed reviewers:
+ dcheng@chromium.org, dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-06-15 17:48:16]

+dcheng@ who had some good ideas on the bug.  I think we rename this to
drag_traits_messages.h so that it gets defaulted to OWNERS:
file://ipc/SECURITY_OWNERS.

[David Trainor- moved to gerrit, 2017-06-15 17:49:45]

On 2017/06/15 17:48:16, David Trainor-ping after 12h wrote:
> +dcheng@ who had some good ideas on the bug.  I think we rename this to
> drag_traits_messages.h so that it gets defaulted to OWNERS:
> file://ipc/SECURITY_OWNERS.

Ah sorry that was a bad suggestion.  Instead add the this traits file to
content/common/OWNERS like the other *traits files.  Sorry for the confusion. 
dcheng@ let me know if this updated advice is incorrect.  Thanks!

[dcheng, 2017-06-15 19:33:52]

On 2017/06/15 17:49:45, David Trainor-ping after 12h wrote:
> On 2017/06/15 17:48:16, David Trainor-ping after 12h wrote:
> > +dcheng@ who had some good ideas on the bug.  I think we rename this to
> > drag_traits_messages.h so that it gets defaulted to OWNERS:
> > file://ipc/SECURITY_OWNERS.
> 
> Ah sorry that was a bad suggestion.  Instead add the this traits file to
> content/common/OWNERS like the other *traits files.  Sorry for the confusion. 
> dcheng@ let me know if this updated advice is incorrect.  Thanks!

Renaming to drag_param_traits.h seems reasonable to me (and matches the
convention for legacy IPC).

https://codereview.chromium.org/2928353002/diff/1/content/common/drag_traits.h
File content/common/drag_traits.h (right):

https://codereview.chromium.org/2928353002/diff/1/content/common/drag_traits....
content/common/drag_traits.h:27:
IPC_STRUCT_TRAITS_MEMBER(did_originate_from_renderer)
I'm not sure if we should plumb this one through. It's used only on the browser
side for checks, and we wouldn't want to trust this bit when it comes from the
renderer anyway.

https://codereview.chromium.org/2928353002/diff/1/content/common/drag_traits....
content/common/drag_traits.h:33: IPC_STRUCT_TRAITS_MEMBER(file_mime_types)
Similarly it doesn't seem like this is actually used except for generating
DropData::Metadata. So maybe it doesn't belong in drop data?