content/common/drag_traits.h - Issue 2928353002: Declare missing fields of DropData in IPC_STRUCT_TRAITS

Side by Side Diff: content/common/drag_traits.h

Issue 2928353002: Declare missing fields of DropData in IPC_STRUCT_TRAITS

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/common/drag_event_source_info.h"	5 #include "content/common/drag_event_source_info.h"

6 #include "content/public/common/common_param_traits.h"	6 #include "content/public/common/common_param_traits.h"

7 #include "content/public/common/drop_data.h"	7 #include "content/public/common/drop_data.h"

8 #include "ipc/ipc_message_macros.h"	8 #include "ipc/ipc_message_macros.h"

9 #include "third_party/WebKit/public/platform/WebDragOperation.h"	9 #include "third_party/WebKit/public/platform/WebDragOperation.h"

10 #include "ui/gfx/geometry/point.h"	10 #include "ui/gfx/geometry/point.h"

11	11

12 #define IPC_MESSAGE_START DragMsgStart	12 #define IPC_MESSAGE_START DragMsgStart

13	13

14 IPC_ENUM_TRAITS(blink::WebDragOperation) // Bitmask.	14 IPC_ENUM_TRAITS(blink::WebDragOperation) // Bitmask.

15 IPC_ENUM_TRAITS_MAX_VALUE(ui::DragDropTypes::DragEventSource,	15 IPC_ENUM_TRAITS_MAX_VALUE(ui::DragDropTypes::DragEventSource,

16 ui::DragDropTypes::DRAG_EVENT_SOURCE_LAST)	16 ui::DragDropTypes::DRAG_EVENT_SOURCE_LAST)

17 IPC_ENUM_TRAITS_MAX_VALUE(content::DropData::Kind,	17 IPC_ENUM_TRAITS_MAX_VALUE(content::DropData::Kind,

18 content::DropData::Kind::LAST)	18 content::DropData::Kind::LAST)

19	19

20 IPC_STRUCT_TRAITS_BEGIN(ui::FileInfo)	20 IPC_STRUCT_TRAITS_BEGIN(ui::FileInfo)

21 IPC_STRUCT_TRAITS_MEMBER(path)	21 IPC_STRUCT_TRAITS_MEMBER(path)

22 IPC_STRUCT_TRAITS_MEMBER(display_name)	22 IPC_STRUCT_TRAITS_MEMBER(display_name)

23 IPC_STRUCT_TRAITS_END()	23 IPC_STRUCT_TRAITS_END()

24	24

25 IPC_STRUCT_TRAITS_BEGIN(content::DropData)	25 IPC_STRUCT_TRAITS_BEGIN(content::DropData)

26 IPC_STRUCT_TRAITS_MEMBER(key_modifiers)	26 IPC_STRUCT_TRAITS_MEMBER(key_modifiers)

	27 IPC_STRUCT_TRAITS_MEMBER(did_originate_from_renderer)
	dcheng 2017/06/15 19:33:52 I'm not sure if we should plumb this one through. I'm not sure if we should plumb this one through. It's used only on the browser side for checks, and we wouldn't want to trust this bit when it comes from the renderer anyway.
27 IPC_STRUCT_TRAITS_MEMBER(url)	28 IPC_STRUCT_TRAITS_MEMBER(url)

28 IPC_STRUCT_TRAITS_MEMBER(url_title)	29 IPC_STRUCT_TRAITS_MEMBER(url_title)

29 IPC_STRUCT_TRAITS_MEMBER(download_metadata)	30 IPC_STRUCT_TRAITS_MEMBER(download_metadata)

30 IPC_STRUCT_TRAITS_MEMBER(referrer_policy)	31 IPC_STRUCT_TRAITS_MEMBER(referrer_policy)

31 IPC_STRUCT_TRAITS_MEMBER(filenames)	32 IPC_STRUCT_TRAITS_MEMBER(filenames)

	33 IPC_STRUCT_TRAITS_MEMBER(file_mime_types)
	dcheng 2017/06/15 19:33:52 Similarly it doesn't seem like this is actually us Similarly it doesn't seem like this is actually used except for generating DropData::Metadata. So maybe it doesn't belong in drop data?
32 IPC_STRUCT_TRAITS_MEMBER(filesystem_id)	34 IPC_STRUCT_TRAITS_MEMBER(filesystem_id)

33 IPC_STRUCT_TRAITS_MEMBER(file_system_files)	35 IPC_STRUCT_TRAITS_MEMBER(file_system_files)

34 IPC_STRUCT_TRAITS_MEMBER(text)	36 IPC_STRUCT_TRAITS_MEMBER(text)

35 IPC_STRUCT_TRAITS_MEMBER(html)	37 IPC_STRUCT_TRAITS_MEMBER(html)

36 IPC_STRUCT_TRAITS_MEMBER(html_base_url)	38 IPC_STRUCT_TRAITS_MEMBER(html_base_url)

37 IPC_STRUCT_TRAITS_MEMBER(file_contents)	39 IPC_STRUCT_TRAITS_MEMBER(file_contents)

38 IPC_STRUCT_TRAITS_MEMBER(file_contents_source_url)	40 IPC_STRUCT_TRAITS_MEMBER(file_contents_source_url)

39 IPC_STRUCT_TRAITS_MEMBER(file_contents_filename_extension)	41 IPC_STRUCT_TRAITS_MEMBER(file_contents_filename_extension)

40 IPC_STRUCT_TRAITS_MEMBER(file_contents_content_disposition)	42 IPC_STRUCT_TRAITS_MEMBER(file_contents_content_disposition)

41 IPC_STRUCT_TRAITS_MEMBER(custom_data)	43 IPC_STRUCT_TRAITS_MEMBER(custom_data)

42 IPC_STRUCT_TRAITS_END()	44 IPC_STRUCT_TRAITS_END()

43	45

44 IPC_STRUCT_TRAITS_BEGIN(content::DropData::FileSystemFileInfo)	46 IPC_STRUCT_TRAITS_BEGIN(content::DropData::FileSystemFileInfo)

45 IPC_STRUCT_TRAITS_MEMBER(url)	47 IPC_STRUCT_TRAITS_MEMBER(url)

46 IPC_STRUCT_TRAITS_MEMBER(size)	48 IPC_STRUCT_TRAITS_MEMBER(size)

47 IPC_STRUCT_TRAITS_MEMBER(filesystem_id)	49 IPC_STRUCT_TRAITS_MEMBER(filesystem_id)

48 IPC_STRUCT_TRAITS_END()	50 IPC_STRUCT_TRAITS_END()

49	51

50 IPC_STRUCT_TRAITS_BEGIN(content::DropData::Metadata)	52 IPC_STRUCT_TRAITS_BEGIN(content::DropData::Metadata)

51 IPC_STRUCT_TRAITS_MEMBER(kind)	53 IPC_STRUCT_TRAITS_MEMBER(kind)

52 IPC_STRUCT_TRAITS_MEMBER(mime_type)	54 IPC_STRUCT_TRAITS_MEMBER(mime_type)

53 IPC_STRUCT_TRAITS_MEMBER(filename)	55 IPC_STRUCT_TRAITS_MEMBER(filename)

54 IPC_STRUCT_TRAITS_MEMBER(file_system_url)	56 IPC_STRUCT_TRAITS_MEMBER(file_system_url)

55 IPC_STRUCT_TRAITS_END()	57 IPC_STRUCT_TRAITS_END()

56	58

57 IPC_STRUCT_TRAITS_BEGIN(content::DragEventSourceInfo)	59 IPC_STRUCT_TRAITS_BEGIN(content::DragEventSourceInfo)

58 IPC_STRUCT_TRAITS_MEMBER(event_location)	60 IPC_STRUCT_TRAITS_MEMBER(event_location)

59 IPC_STRUCT_TRAITS_MEMBER(event_source)	61 IPC_STRUCT_TRAITS_MEMBER(event_source)

60 IPC_STRUCT_TRAITS_END()	62 IPC_STRUCT_TRAITS_END()

OLD	NEW