Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2928343002: Update histogram's names for ChromeArcVideoDecodeAccelerator. (Closed)

Created:
3 years, 6 months ago by Owen Lin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update histogram's names for ChromeArcVideoDecodeAccelerator. The names was updated in https://codereview.chromium.org/2919193002/. Need to update the values in the histograms to keep them synced. BUG=732192 TEST=None Review-Url: https://codereview.chromium.org/2928343002 Cr-Commit-Position: refs/heads/master@{#479340} Committed: https://chromium.googlesource.com/chromium/src/+/5bd0cd64767258a6294c1be9d4e5e9d883bc8cb9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark old entries as obsolete. #

Total comments: 1

Patch Set 3 : Use the renamed enum in the obsoleted histogram. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M tools/metrics/histograms/enums.xml View 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Owen Lin
PTAL. Thank you.
3 years, 6 months ago (2017-06-12 03:55:31 UTC) #2
Pawel Osciak
https://codereview.chromium.org/2928343002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2928343002/diff/1/tools/metrics/histograms/histograms.xml#oldcode27172 tools/metrics/histograms/histograms.xml:27172: -<histogram name="Media.ArcGpuVideoDecodeAccelerator.InitializeResult" We may need to mark this as ...
3 years, 6 months ago (2017-06-12 04:06:57 UTC) #3
Owen Lin
https://codereview.chromium.org/2928343002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2928343002/diff/1/tools/metrics/histograms/histograms.xml#oldcode27172 tools/metrics/histograms/histograms.xml:27172: -<histogram name="Media.ArcGpuVideoDecodeAccelerator.InitializeResult" On 2017/06/12 04:06:57, Pawel Osciak wrote: > ...
3 years, 6 months ago (2017-06-12 06:00:46 UTC) #4
Ilya Sherman
LGTM, though I'd recommend not renaming the enum (see inline comment). https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histograms/enums.xml File tools/metrics/histograms/enums.xml (right): ...
3 years, 6 months ago (2017-06-12 20:08:26 UTC) #5
Owen Lin
On 2017/06/12 20:08:26, Ilya Sherman wrote: > LGTM, though I'd recommend not renaming the enum ...
3 years, 6 months ago (2017-06-13 04:50:25 UTC) #6
Ilya Sherman
On 2017/06/13 04:50:25, Owen Lin wrote: > On 2017/06/12 20:08:26, Ilya Sherman wrote: > > ...
3 years, 6 months ago (2017-06-13 05:03:34 UTC) #7
Owen Lin
On 2017/06/13 05:03:34, Ilya Sherman wrote: > On 2017/06/13 04:50:25, Owen Lin wrote: > > ...
3 years, 6 months ago (2017-06-14 07:04:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928343002/40001
3 years, 6 months ago (2017-06-14 07:05:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/249710)
3 years, 6 months ago (2017-06-14 08:14:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928343002/40001
3 years, 6 months ago (2017-06-14 08:27:32 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 09:51:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5bd0cd64767258a6294c1be9d4e5...

Powered by Google App Engine
This is Rietveld 408576698