Update histogram's names for ChromeArcVideoDecodeAccelerator.

Update histogram's names for ChromeArcVideoDecodeAccelerator.

The names was updated in https://codereview.chromium.org/2919193002/.
Need to update the values in the histograms to keep them synced.

BUG=732192
TEST=None

Review-Url: https://codereview.chromium.org/2928343002
Cr-Commit-Position: refs/heads/master@{#479340}
Committed: https://chromium.googlesource.com/chromium/src/+/5bd0cd64767258a6294c1be9d4e5e9d883bc8cb9

[Owen Lin, 2017-06-12 03:55:31]

owenlin@chromium.org changed reviewers:
+ isherman@chromium.org, johnylin@chromium.org, posciak@chromium.org

[Owen Lin, 2017-06-12 03:55:31]

PTAL. Thank you.

[Pawel Osciak, 2017-06-12 04:06:57]

https://codereview.chromium.org/2928343002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2928343002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:27172: -<histogram
name="Media.ArcGpuVideoDecodeAccelerator.InitializeResult"
We may need to mark this as obsolete instead:

https://cs.chromium.org/chromium/src/tools/metrics/histograms/README.md?q=his...

[Owen Lin, 2017-06-12 06:00:46]

https://codereview.chromium.org/2928343002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2928343002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:27172: -<histogram
name="Media.ArcGpuVideoDecodeAccelerator.InitializeResult"
On 2017/06/12 04:06:57, Pawel Osciak wrote:
> We may need to mark this as obsolete instead:
> 
>
https://cs.chromium.org/chromium/src/tools/metrics/histograms/README.md?q=his...

Thanks. Updated.

[Ilya Sherman, 2017-06-12 20:08:26]

LGTM, though I'd recommend not renaming the enum (see inline comment).

https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/enums.xml (right):

https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/enums.xml:1243: +</enum>
Hmm, why are you renaming this enum?  It seems identical to the obsoleted one --
am I missing something?

[Owen Lin, 2017-06-13 04:50:25]

On 2017/06/12 20:08:26, Ilya Sherman wrote:
> LGTM, though I'd recommend not renaming the enum (see inline comment).
> 
>
https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histogram...
> File tools/metrics/histograms/enums.xml (right):
> 
>
https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histogram...
> tools/metrics/histograms/enums.xml:1243: +</enum>
> Hmm, why are you renaming this enum?  It seems identical to the obsoleted one
--
> am I missing something?

They are identical. Rename it to match the corresponding enum in 
https://cs.chromium.org/chromium/src/chrome/gpu/arc_video_decode_accelerator....

[Ilya Sherman, 2017-06-13 05:03:34]

On 2017/06/13 04:50:25, Owen Lin wrote:
> On 2017/06/12 20:08:26, Ilya Sherman wrote:
> > LGTM, though I'd recommend not renaming the enum (see inline comment).
> > 
> >
>
https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histogram...
> > File tools/metrics/histograms/enums.xml (right):
> > 
> >
>
https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histogram...
> > tools/metrics/histograms/enums.xml:1243: +</enum>
> > Hmm, why are you renaming this enum?  It seems identical to the obsoleted
one
> --
> > am I missing something?
> 
> They are identical. Rename it to match the corresponding enum in 
>
https://cs.chromium.org/chromium/src/chrome/gpu/arc_video_decode_accelerator....

I'd recommend just using the renamed enum for the obsoleted histogram, though up
to you if you prefer not to.

[Owen Lin, 2017-06-14 07:04:18]

On 2017/06/13 05:03:34, Ilya Sherman wrote:
> On 2017/06/13 04:50:25, Owen Lin wrote:
> > On 2017/06/12 20:08:26, Ilya Sherman wrote:
> > > LGTM, though I'd recommend not renaming the enum (see inline comment).
> > > 
> > >
> >
>
https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histogram...
> > > File tools/metrics/histograms/enums.xml (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2928343002/diff/20001/tools/metrics/histogram...
> > > tools/metrics/histograms/enums.xml:1243: +</enum>
> > > Hmm, why are you renaming this enum?  It seems identical to the obsoleted
> one
> > --
> > > am I missing something?
> > 
> > They are identical. Rename it to match the corresponding enum in 
> >
>
https://cs.chromium.org/chromium/src/chrome/gpu/arc_video_decode_accelerator....
> 
> I'd recommend just using the renamed enum for the obsoleted histogram, though
up
> to you if you prefer not to.

It sounds good. Let's do it.

[Owen Lin, 2017-06-14 07:05:06]

The CQ bit was checked by owenlin@chromium.org

[Owen Lin, 2017-06-14 07:05:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2928343002/#ps40001
(title: "Use the renamed enum in the obsoleted histogram.")

[commit-bot: I haz the power, 2017-06-14 07:05:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 08:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 08:14:51]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Owen Lin, 2017-06-14 08:27:16]

The CQ bit was checked by owenlin@chromium.org

[commit-bot: I haz the power, 2017-06-14 08:27:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 09:50:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497428836678210,
"parent_rev": "335a187fa49bf9bcb98840782e46fbb697bf2893", "commit_rev":
"5bd0cd64767258a6294c1be9d4e5e9d883bc8cb9"}

[commit-bot: I haz the power, 2017-06-14 09:51:10]

Description was changed from

==========
Update histogram's names for ChromeArcVideoDecodeAccelerator.

The names was updated in https://codereview.chromium.org/2919193002/.
Need to update the values in the histograms to keep them synced.

BUG=732192
TEST=None
==========

to

==========
Update histogram's names for ChromeArcVideoDecodeAccelerator.

The names was updated in https://codereview.chromium.org/2919193002/.
Need to update the values in the histograms to keep them synced.

BUG=732192
TEST=None

Review-Url: https://codereview.chromium.org/2928343002
Cr-Commit-Position: refs/heads/master@{#479340}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd0cd64767258a6294c1be9d4e5...
==========

[commit-bot: I haz the power, 2017-06-14 09:51:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5bd0cd64767258a6294c1be9d4e5...