Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: components/offline_pages/core/prefetch/prefetch_proto_utils.h

Issue 2928243002: Return operation name in prefetch request callback and add internal page hookup (Closed)
Patch Set: Fix comment indent in JS Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/prefetch/prefetch_proto_utils.h
diff --git a/components/offline_pages/core/prefetch/prefetch_proto_utils.h b/components/offline_pages/core/prefetch/prefetch_proto_utils.h
index cc77de109bdcbdfd505442ed5bce6189efe75120..92813af8e2eec4a131bbd5c70271abec2f0d9c5c 100644
--- a/components/offline_pages/core/prefetch/prefetch_proto_utils.h
+++ b/components/offline_pages/core/prefetch/prefetch_proto_utils.h
@@ -5,6 +5,7 @@
#ifndef COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_PROTO_UTILS_H_
#define COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_PROTO_UTILS_H_
+#include <string>
#include <vector>
#include "components/offline_pages/core/prefetch/prefetch_types.h"
@@ -13,9 +14,10 @@ namespace offline_pages {
// The fully qualified type name for PageBundle defined in proto.
extern const char kPageBundleTypeURL[];
-// Used to parse the Operation serialized in binary proto |data|.
-bool ParseOperationResponse(const std::string& data,
- std::vector<RenderPageInfo>* pages);
+// Parse the Operation serialized in binary proto |data|. Returns the operation
+// name if parsing succeeded. Otherwise, empty string is returned.
+std::string ParseOperationResponse(const std::string& data,
+ std::vector<RenderPageInfo>* pages);
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698