Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3452)

Unified Diff: components/offline_pages/core/prefetch/get_operation_request_unittest.cc

Issue 2928243002: Return operation name in prefetch request callback and add internal page hookup (Closed)
Patch Set: Fix comment indent in JS Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/prefetch/get_operation_request_unittest.cc
diff --git a/components/offline_pages/core/prefetch/get_operation_request_unittest.cc b/components/offline_pages/core/prefetch/get_operation_request_unittest.cc
index b104888ffe70d4cce736d36e5c9848e18842cea4..45f271766e2e491217bf71a6026835a57cef69d0 100644
--- a/components/offline_pages/core/prefetch/get_operation_request_unittest.cc
+++ b/components/offline_pages/core/prefetch/get_operation_request_unittest.cc
@@ -63,12 +63,15 @@ TEST_F(GetOperationRequestTest, EmptyResponse) {
std::unique_ptr<GetOperationRequest> request(CreateRequest(callback.Get()));
PrefetchRequestStatus status;
+ std::string operation_name;
std::vector<RenderPageInfo> pages;
- EXPECT_CALL(callback, Run(_, _))
- .WillOnce(DoAll(SaveArg<0>(&status), SaveArg<1>(&pages)));
+ EXPECT_CALL(callback, Run(_, _, _))
+ .WillOnce(DoAll(SaveArg<0>(&status), SaveArg<1>(&operation_name),
+ SaveArg<2>(&pages)));
RespondWithData("");
EXPECT_EQ(PrefetchRequestStatus::SHOULD_RETRY_WITH_BACKOFF, status);
+ EXPECT_TRUE(operation_name.empty());
EXPECT_TRUE(pages.empty());
}
@@ -77,12 +80,15 @@ TEST_F(GetOperationRequestTest, InvalidResponse) {
std::unique_ptr<GetOperationRequest> request(CreateRequest(callback.Get()));
PrefetchRequestStatus status;
+ std::string operation_name;
std::vector<RenderPageInfo> pages;
- EXPECT_CALL(callback, Run(_, _))
- .WillOnce(DoAll(SaveArg<0>(&status), SaveArg<1>(&pages)));
+ EXPECT_CALL(callback, Run(_, _, _))
+ .WillOnce(DoAll(SaveArg<0>(&status), SaveArg<1>(&operation_name),
+ SaveArg<2>(&pages)));
RespondWithData("Some invalid data");
EXPECT_EQ(PrefetchRequestStatus::SHOULD_RETRY_WITH_BACKOFF, status);
+ EXPECT_TRUE(operation_name.empty());
EXPECT_TRUE(pages.empty());
}

Powered by Google App Engine
This is Rietveld 408576698