Issue 2928153003: [Mac] Fix the URL on the Fullscreen Touch Bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2928153003: [Mac] Fix the URL on the Fullscreen Touch Bar (Closed)

Created:
3 years, 6 months ago by spqchan

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews, mac-reviews_chromium.org

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

[Mac] Fix the URL on the Fullscreen Touch Bar Calculate the url's path index with GetEmptyPath() since the previous method wouldn't play nicely with queries and etc. Bug: 720120 Change-Id: Icbd609e02d43f043f75b2614ee5ffcc68497a4a8 Reviewed-on: https://chromium-review.googlesource.com/517503 Reviewed-by: Avi Drissman <avi@chromium.org>; Commit-Queue: Sarah Chan <spqchan@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#475203} Review-Url: https://codereview.chromium.org/2928153003 . Cr-Commit-Position: refs/branch-heads/3112@{#291} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/a64899eae8fa75447b24051b3f5a1add3a2000ef

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/ui/cocoa/browser_window_touch_bar.mm	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

spqchan

3 years, 6 months ago (2017-06-09 18:38:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a64899eae8fa75447b24051b3f5a1add3a2000ef.