Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2928133005: Revert of [Chromoting] Add DataChannelManager to manage optional incoming data channels (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, joedow
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Add DataChannelManager to manage optional incoming data channels (patchset #8 id:320001 of https://codereview.chromium.org/2907073003/ ) Reason for revert: New unittests are failing: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F19251%2F%2B%2Frecipes%2Fsteps%2Fremoting_unittests_on_Mac-10.10%2F0%2Flogs%2FDataChannelManagerTest.FullMatchWithAsynchronousPipe%2F0 Original issue's description: > [Chromoting] Add DataChannelManager to manage optional incoming data channels > > DataChannelManager manages a set of factory functions to create > DataChannelHandler instances to handle named data channels. So once the peer > creates a new data channel, DataChannelManager can automatically handle it. > Lifetime of a DataChannelHandler is consistent with the MessagePipe it received: > it deletes itself once the MessagePipe is closed. > > BUG=650926 > > Review-Url: https://codereview.chromium.org/2907073003 > Cr-Commit-Position: refs/heads/master@{#478442} > Committed: https://chromium.googlesource.com/chromium/src/+/4a15f818c5fdbd1e2c44bf102047ecd9b2c166e2 TBR=sergeyu@chromium.org,joedow@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650926 Review-Url: https://codereview.chromium.org/2928133005 Cr-Commit-Position: refs/heads/master@{#478485} Committed: https://chromium.googlesource.com/chromium/src/+/d3b81665f23d2192c448b17698eb89b3f4988ee5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -807 lines) Patch
M remoting/proto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/proto/test.proto View 1 chunk +0 lines, -17 lines 0 comments Download
M remoting/protocol/BUILD.gn View 4 chunks +0 lines, -9 lines 0 comments Download
D remoting/protocol/data_channel_manager.h View 1 chunk +0 lines, -47 lines 0 comments Download
D remoting/protocol/data_channel_manager.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D remoting/protocol/data_channel_manager_unittest.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D remoting/protocol/fake_message_pipe.h View 1 chunk +0 lines, -66 lines 0 comments Download
D remoting/protocol/fake_message_pipe.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D remoting/protocol/fake_message_pipe_wrapper.h View 1 chunk +0 lines, -46 lines 0 comments Download
D remoting/protocol/fake_message_pipe_wrapper.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D remoting/protocol/named_message_pipe_handler.h View 1 chunk +0 lines, -77 lines 0 comments Download
D remoting/protocol/named_message_pipe_handler.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M remoting/protocol/webrtc_data_stream_adapter.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Devlin
Created Revert of [Chromoting] Add DataChannelManager to manage optional incoming data channels
3 years, 6 months ago (2017-06-10 01:06:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928133005/1
3 years, 6 months ago (2017-06-10 01:06:51 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-10 01:07:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3b81665f23d2192c448b17698eb...

Powered by Google App Engine
This is Rietveld 408576698