DescriptionRevert of [Chromoting] Add DataChannelManager to manage optional incoming data channels (patchset #8 id:320001 of https://codereview.chromium.org/2907073003/ )
Reason for revert:
New unittests are failing:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F19251%2F%2B%2Frecipes%2Fsteps%2Fremoting_unittests_on_Mac-10.10%2F0%2Flogs%2FDataChannelManagerTest.FullMatchWithAsynchronousPipe%2F0
Original issue's description:
> [Chromoting] Add DataChannelManager to manage optional incoming data channels
>
> DataChannelManager manages a set of factory functions to create
> DataChannelHandler instances to handle named data channels. So once the peer
> creates a new data channel, DataChannelManager can automatically handle it.
> Lifetime of a DataChannelHandler is consistent with the MessagePipe it received:
> it deletes itself once the MessagePipe is closed.
>
> BUG=650926
>
> Review-Url: https://codereview.chromium.org/2907073003
> Cr-Commit-Position: refs/heads/master@{#478442}
> Committed: https://chromium.googlesource.com/chromium/src/+/4a15f818c5fdbd1e2c44bf102047ecd9b2c166e2
TBR=sergeyu@chromium.org,joedow@chromium.org,zijiehe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=650926
Review-Url: https://codereview.chromium.org/2928133005
Cr-Commit-Position: refs/heads/master@{#478485}
Committed: https://chromium.googlesource.com/chromium/src/+/d3b81665f23d2192c448b17698eb89b3f4988ee5
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|