Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2928133002: Launch new gain control tuning value for WebRTC's AGC (Closed)

Created:
3 years, 6 months ago by hlundin-chromium
Modified:
3 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Launch new gain control tuning value for WebRTC's AGC This change sets the new default value for "clipping level min" to 70, and dismantles the experiment. BUG=672476 Review-Url: https://codereview.chromium.org/2928133002 Cr-Commit-Position: refs/heads/master@{#478612} Committed: https://chromium.googlesource.com/chromium/src/+/10386e8372ef3cd50e14bec6264a0677015dd998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -33 lines) Patch
M content/renderer/media/media_stream_audio_processor.cc View 2 chunks +4 lines, -33 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
hlundin-chromium
Guido, PTAL. Thanks!
3 years, 6 months ago (2017-06-09 12:00:38 UTC) #3
hlundin-chromium
3 years, 6 months ago (2017-06-12 12:12:47 UTC) #5
tommi (sloooow) - chröme
lgtm
3 years, 6 months ago (2017-06-12 12:14:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928133002/1
3 years, 6 months ago (2017-06-12 12:15:02 UTC) #8
Guido Urdaneta
lgtm
3 years, 6 months ago (2017-06-12 12:16:07 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 14:24:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10386e8372ef3cd50e14bec6264a...

Powered by Google App Engine
This is Rietveld 408576698