Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2928083003:
Introduce AdjustInlineBoxPositionForTextDirection() for ComputeInlineBoxPosition() (Closed)
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionIntroduce AdjustInlineBoxPositionForTextDirection() for ComputeInlineBoxPosition()
This patch introduces |AdjustInlineBoxPositionForTextDirection()| which is
split from |ComputeInlineBoxPosition()| to reduce source code size of
|ComputeInlineBoxPosition()| for improving code health.
BUG=707656
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2928083003
Cr-Commit-Position: refs/heads/master@{#478544}
Committed: https://chromium.googlesource.com/chromium/src/+/85c02b2c4d6c4a9fe3025ba70d98324be01b994e
Patch Set 1 : 2017-06-09T16:24:59 #
Messages
Total messages: 21 (17 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== 2017-06-09T15:38:37 BUG= 2017-06-09T15:38:33 ========== to ========== Introduce AdjustInlineBoxPositionForTextDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForTextDirection()| which is split from |ComputeInlineBoxPosition()| to reduce source code size of |ComputeInlineBoxPosition()| for improving code health. BUG=707656 TEST=n/a; no behavior changes ==========
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL This patch makes size of ComputeInlineBoxPosition() to half. (^_^)b
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497231619355690,
"parent_rev": "f8f46de2517307a1a0c72f1c41b72594e21028d3", "commit_rev":
"85c02b2c4d6c4a9fe3025ba70d98324be01b994e"}
Message was sent while issue was closed.
Description was changed from ========== Introduce AdjustInlineBoxPositionForTextDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForTextDirection()| which is split from |ComputeInlineBoxPosition()| to reduce source code size of |ComputeInlineBoxPosition()| for improving code health. BUG=707656 TEST=n/a; no behavior changes ========== to ========== Introduce AdjustInlineBoxPositionForTextDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForTextDirection()| which is split from |ComputeInlineBoxPosition()| to reduce source code size of |ComputeInlineBoxPosition()| for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2928083003 Cr-Commit-Position: refs/heads/master@{#478544} Committed: https://chromium.googlesource.com/chromium/src/+/85c02b2c4d6c4a9fe3025ba70d98... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/85c02b2c4d6c4a9fe3025ba70d98... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
