Add nednguyen@ and haraken@ as OWNER of third_party/WebKit/PerformanceTests/

Add nednguyen@ and haraken@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently takes ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

In term of code familiarity, I have made sizable 
feature changes to the test framework in this directory (crbug.com/701059) & authored documentation for writing blink perf tests  (https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/PerformanceTests/README.md)

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory. 

In term of process, this means that I will be responsible for reviewing all the 
commits in this folder. In longer term, I plan to grow other member of speed 
benchmarking team to also become maintainers of this directory.

Review-Url: https://codereview.chromium.org/2928083002
Cr-Commit-Position: refs/heads/master@{#478593}
Committed: https://chromium.googlesource.com/chromium/src/+/ec134f43c4436037b1f78723f1f7ed220d80aebe

[nednguyen, 2017-06-09 01:27:18]

Description was changed from

==========
Add nednguyen@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently take ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory.

In term of process, this means that I will get to review all the CLs going to
this folder. In longer term, I am looking for growing other member of speed
benchmarking team to also become OWNERS.
==========

to

==========
Add nednguyen@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently take ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory.

In term of process, this means that I will get to review all the commits in 
this folder. In longer term, I plan to grow other member of speed
benchmarking team to also become OWNERS.
==========

[nednguyen, 2017-06-09 01:29:39]

nednguyen@google.com changed reviewers:
+ chrishtr@chromium.org, darin@chromium.org, dglazkov@chromium.org,
foolip@chromium.org, jochen@chromium.org, rbyers@chromium.org,
tkent@chromium.org

[nednguyen, 2017-06-09 01:36:13]

Description was changed from

==========
Add nednguyen@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently take ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory.

In term of process, this means that I will get to review all the commits in 
this folder. In longer term, I plan to grow other member of speed
benchmarking team to also become OWNERS.
==========

to

==========
Add nednguyen@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently takes ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

In term of code familiarity, I have made sizable 
feature changes to the test framework in this directory (crbug.com/701059) &
authored documentation for writing blink perf tests 
(https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Pe...)

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory. 

In term of process, this means that I will be responsible for reviewing all the 
commits in this folder. In longer term, I plan to grow other member of speed 
benchmarking team to also become maintainers of this directory.
==========

[Dirk Pranke, 2017-06-09 01:55:27]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-06-09 01:55:27]

This change LGTM (I am technically an OWNER, but we should get approval from one
of the other reviewers as well).

[Rick Byers, 2017-06-09 02:44:32]

Yep, this is great - thank you!  LGTM

It's not urgent (since there's no 'set noparent' here), but will you work
towards having more OWNER(s) here (since we generally try to avoid directories
with single owners in case of vacation)?

[Rick Byers, 2017-06-09 02:44:58]

On 2017/06/09 02:44:32, Rick Byers wrote:
> Yep, this is great - thank you!  LGTM
> 
> It's not urgent (since there's no 'set noparent' here), but will you work
> towards having more OWNER(s) here (since we generally try to avoid directories
> with single owners in case of vacation)?

Oh sorry - I see you already answered this :-)

[jochen (gone - plz use gerrit), 2017-06-09 02:48:29]

historically, TOK has worked a lot in this directory. As you remove *, I wonder
whether we should add e.g. haraken for the time being to ensure appropriate
timezone coverage?

[Rick Byers, 2017-06-09 02:59:11]

On 2017/06/09 02:48:29, jochen wrote:
> historically, TOK has worked a lot in this directory. As you remove *, I
wonder
> whether we should add e.g. haraken for the time being to ensure appropriate
> timezone coverage?

Good point, I know APAC folks not having an APAC reviewer can really slow down
iteration.

[nednguyen(REVIEW IN OTHER ACC), 2017-06-09 03:31:26]

On 2017/06/09 02:59:11, Rick Byers wrote:
> On 2017/06/09 02:48:29, jochen wrote:
> > historically, TOK has worked a lot in this directory. As you remove *, I
> wonder
> > whether we should add e.g. haraken for the time being to ensure appropriate
> > timezone coverage?
> 
> Good point, I know APAC folks not having an APAC reviewer can really slow down
> iteration.

+Haraken: are you ok with being an owner here as well?

[nednguyen(REVIEW IN OTHER ACC), 2017-06-09 03:31:52]

nednguyen@chromium.org changed reviewers:
+ haraken@chromium.org

[chrishtr, 2017-06-09 03:33:57]

lgtm

[haraken, 2017-06-09 03:47:19]

LGTM

[nednguyen(REVIEW IN OTHER ACC), 2017-06-09 13:07:49]

Description was changed from

==========
Add nednguyen@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently takes ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

In term of code familiarity, I have made sizable 
feature changes to the test framework in this directory (crbug.com/701059) &
authored documentation for writing blink perf tests 
(https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Pe...)

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory. 

In term of process, this means that I will be responsible for reviewing all the 
commits in this folder. In longer term, I plan to grow other member of speed 
benchmarking team to also become maintainers of this directory.
==========

to

==========
Add nednguyen@ and haraken@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently takes ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

In term of code familiarity, I have made sizable 
feature changes to the test framework in this directory (crbug.com/701059) &
authored documentation for writing blink perf tests 
(https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Pe...)

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory. 

In term of process, this means that I will be responsible for reviewing all the 
commits in this folder. In longer term, I plan to grow other member of speed 
benchmarking team to also become maintainers of this directory.
==========

[nednguyen, 2017-06-12 10:43:41]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-06-12 10:43:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, chrishtr@chromium.org, rbyers@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2928083002/#ps20001
(title: "Add haraken@ as owner")

[commit-bot: I haz the power, 2017-06-12 10:43:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 11:59:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497264221561530,
"parent_rev": "49effc1da26d29e677a79f49cf20ca85be501ee4", "commit_rev":
"ec134f43c4436037b1f78723f1f7ed220d80aebe"}

[commit-bot: I haz the power, 2017-06-12 11:59:22]

Description was changed from

==========
Add nednguyen@ and haraken@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently takes ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

In term of code familiarity, I have made sizable 
feature changes to the test framework in this directory (crbug.com/701059) &
authored documentation for writing blink perf tests 
(https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Pe...)

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory. 

In term of process, this means that I will be responsible for reviewing all the 
commits in this folder. In longer term, I plan to grow other member of speed 
benchmarking team to also become maintainers of this directory.
==========

to

==========
Add nednguyen@ and haraken@ as OWNER of third_party/WebKit/PerformanceTests/

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently takes ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

In term of code familiarity, I have made sizable 
feature changes to the test framework in this directory (crbug.com/701059) &
authored documentation for writing blink perf tests 
(https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Pe...)

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory. 

In term of process, this means that I will be responsible for reviewing all the 
commits in this folder. In longer term, I plan to grow other member of speed 
benchmarking team to also become maintainers of this directory.

Review-Url: https://codereview.chromium.org/2928083002
Cr-Commit-Position: refs/heads/master@{#478593}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec134f43c4436037b1f78723f1f7...
==========

[commit-bot: I haz the power, 2017-06-12 11:59:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ec134f43c4436037b1f78723f1f7...