Separate out ClosureAnalysisInfo to separate interfaces between what

Separate out ClosureAnalysisInfo to separate interfaces between what
the SSA builder needs to know and what the locals handler needs.

BUG=
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/d9015a73eac12e9b0693b3a3c8617dd40bbe10bc

[Emily Fortuna, 2017-06-09 00:40:26]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-06-09 00:41:00]

efortuna@google.com changed reviewers:
+ johnniwinther@google.com

[Emily Fortuna, 2017-06-09 00:41:01]

(there's a lot more where this came from obviously.)

[Emily Fortuna, 2017-06-09 00:45:17]

Patchset #1 (id:20001) has been deleted

[Emily Fortuna, 2017-06-09 01:01:11]

Patchset #1 (id:40001) has been deleted

[Johnni Winther, 2017-06-09 10:12:40]

lgtm

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:53: Local get context => null;
Mention that this is the aforementioned 'box'. Maybe rename to align [context]
and [requiresBox].

[Emily Fortuna, 2017-06-09 20:27:30]

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:53: Local get context => null;
On 2017/06/09 10:12:40, Johnni Winther wrote:
> Mention that this is the aforementioned 'box'. Maybe rename to align [context]
> and [requiresBox].

good point. updated.

[Emily Fortuna, 2017-06-09 20:29:21]

Description was changed from

==========
Separate out ClosureAnalysisInfo to separate interfaces between what
the SSA builder needs to know and what the locals handler needs.

BUG=
==========

to

==========
Separate out ClosureAnalysisInfo to separate interfaces between what
the SSA builder needs to know and what the locals handler needs.

BUG=
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d9015a73eac12e9b0693b3a3c8617dd40bbe10bc
==========

[Emily Fortuna, 2017-06-09 20:29:22]

Committed patchset #1 (id:60001) manually as
d9015a73eac12e9b0693b3a3c8617dd40bbe10bc (presubmit successful).

[Siggi Cherem (dart-lang), 2017-06-14 22:21:03]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-14 22:21:04]

DBC

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:40: class ClosureAnalysisInfo {
nit: just realized that we commonly use "*Data" as opposed to "*Info" in other
places in the compiler. Maybe consider switching to use "data" here as well?

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:48: bool requiresBox() => false;
nit: I'd turn this into a getter instead: `bool get requiresBox`

[Emily Fortuna, 2017-06-14 23:58:24]

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2928063002/diff/60001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:48: bool requiresBox() => false;
On 2017/06/14 22:21:04, Siggi Cherem (dart-lang) wrote:
> nit: I'd turn this into a getter instead: `bool get requiresBox`

See followup CL: https://codereview.chromium.org/2936323003