Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2936323003: Make requiresContextBox a getter as per Siggi's suggestion. (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make requiresContextBox a getter as per Siggi's suggestion. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7302ea43cffb492593e3c88977c177a5d13948b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Emily Fortuna
3 years, 6 months ago (2017-06-14 23:58:40 UTC) #2
Siggi Cherem (dart-lang)
lgtm, thanks!
3 years, 6 months ago (2017-06-15 00:09:36 UTC) #3
Emily Fortuna
3 years, 6 months ago (2017-06-15 00:12:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7302ea43cffb492593e3c88977c177a5d13948b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698