components/autofill/content/renderer/password_generation_agent.cc - Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)

Patch Set: Split a DCHECK in two as suggested by boliu@. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_generation_agent.cc

diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc

index e7986765a8e42dcc5699bd0ad4950641937daf1f..b4ab0cb2330fc476d7fe92545eb26e211e103ca1 100644

--- a/components/autofill/content/renderer/password_generation_agent.cc

+++ b/components/autofill/content/renderer/password_generation_agent.cc

@@ -591,7 +591,7 @@ void PasswordGenerationAgent::UserTriggeredGeneratePassword() {

password_form = CreatePasswordFormFromWebForm(form, nullptr, nullptr);

control_elements = form_util::ExtractAutofillableElementsInForm(form);

} else {

- const blink::WebFrame& frame = *render_frame()->GetWebFrame();

+ const blink::WebLocalFrame& frame = *render_frame()->GetWebFrame();

blink::WebDocument doc = frame.GetDocument();

if (doc.IsNull())

return;