components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc - Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)

Patch Set: Split a DCHECK in two as suggested by boliu@. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | components/autofill/content/renderer/password_generation_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

index 699caa9cb773973b22e032a279d778d5edcf2810..74f793ecca71518168ad96fd26e742636111860f 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

@@ -27,7 +27,7 @@

using blink::WebFormControlElement;

using blink::WebFormElement;

-using blink::WebFrame;

+using blink::WebLocalFrame;

using blink::WebInputElement;

using blink::WebVector;

@@ -242,7 +242,7 @@ class MAYBE_PasswordFormConversionUtilsTest : public content::RenderViewTest {

void LoadWebFormFromHTML(const std::string& html, WebFormElement* form) {

LoadHTML(html.c_str());

- WebFrame* frame = GetMainFrame();

+ WebLocalFrame* frame = GetMainFrame();

ASSERT_NE(nullptr, frame);

WebVector<WebFormElement> forms;