components/autofill/content/renderer/password_form_conversion_utils.cc - Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 2928033002: Move GetDocument method from WebFrame to WebLocalFrame. (Closed)

Patch Set: Split a DCHECK in two as suggested by boliu@. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils.h ('k') | components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc

index c47feeb6fe4f8ba505f2e82111bed5580be60cc3..6b416039a4264ba0b4816e45d95d5b7b1a5d2348 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc

@@ -29,15 +29,15 @@

#include "third_party/WebKit/public/platform/WebVector.h"

#include "third_party/WebKit/public/web/WebDocument.h"

#include "third_party/WebKit/public/web/WebFormControlElement.h"

-#include "third_party/WebKit/public/web/WebFrame.h"

#include "third_party/WebKit/public/web/WebInputElement.h"

+#include "third_party/WebKit/public/web/WebLocalFrame.h"

#include "third_party/re2/src/re2/re2.h"

using blink::WebDocument;

using blink::WebFormControlElement;

using blink::WebFormElement;

-using blink::WebFrame;

using blink::WebInputElement;

+using blink::WebLocalFrame;

using blink::WebString;

namespace autofill {

@@ -711,7 +711,7 @@ std::unique_ptr<PasswordForm> CreatePasswordFormFromWebForm(

}

std::unique_ptr<PasswordForm> CreatePasswordFormFromUnownedInputElements(

- const WebFrame& frame,

+ const WebLocalFrame& frame,

const FieldValueAndPropertiesMaskMap* field_value_and_properties_map,

const FormsPredictionsMap* form_predictions) {

SyntheticForm synthetic_form;