Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2927993002: Add cross-reference documentation about the forgotten RefCountedDeleteOnSequence. (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
danakj, jam
CC:
chromium-reviews, jam, danakj+watch_chromium.org, darin-cc_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cross-reference documentation about the forgotten RefCountedDeleteOnSequence. BUG=729210 TBR=jam@chromium.org, danakj@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2927993002 Cr-Commit-Position: refs/heads/master@{#478047} Committed: https://chromium.googlesource.com/chromium/src/+/0ad840645e519cfc4ebb9af29ae479e29d296401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/sequenced_task_runner.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/browser_thread.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
gab
TBR dana/jam, this construct was brought to my attention after https://codereview.chromium.org/2921343002 -- and that's why ...
3 years, 6 months ago (2017-06-08 19:06:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927993002/1
3 years, 6 months ago (2017-06-08 19:06:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0ad840645e519cfc4ebb9af29ae479e29d296401
3 years, 6 months ago (2017-06-08 19:12:45 UTC) #7
danakj
3 years, 6 months ago (2017-06-08 19:18:13 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698