Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2927973002: Only use SiteInstance process reuse for ServiceWorker with no failures (Closed)

Created:
3 years, 6 months ago by jam
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Only use SiteInstance process reuse for ServiceWorker with no failures This CL ensures we will only attempt to use the SiteInstance process reuse mechanism when creating a SiteInstance for a ServiceWorker when the ServiceWorker has not failed to start. Otherwise, we will try to start it in a brand new process. BUG=728030 Review-Url: https://codereview.chromium.org/2925623004 Cr-Original-Commit-Position: refs/heads/master@{#477493} Review-Url: https://codereview.chromium.org/2927973002 . Cr-Commit-Position: refs/branch-heads/3112@{#255} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/acaa6e0bf4e2df67012aa1e055d6233e6920d958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -3 lines) Patch
M content/browser/service_worker/service_worker_process_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager_unittest.cc View 4 chunks +98 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jam
3 years, 6 months ago (2017-06-08 17:14:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
acaa6e0bf4e2df67012aa1e055d6233e6920d958.

Powered by Google App Engine
This is Rietveld 408576698