Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2927823003: Explicitly set names for stories in Top10PageSet (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly set names for stories in Top10PageSet BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2927823003 Cr-Commit-Position: refs/heads/master@{#477819} Committed: https://chromium.googlesource.com/chromium/src/+/410db21ea84860f814ae4017eaf36f61c69acced

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/perf/page_sets/top_10.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
ashleymarie1
3 years, 6 months ago (2017-06-07 18:39:23 UTC) #2
ssid
-ssid: I do not have much context. Ned is better reviewer.
3 years, 6 months ago (2017-06-07 18:40:46 UTC) #4
nednguyen
lgtm
3 years, 6 months ago (2017-06-07 20:26:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927823003/1
3 years, 6 months ago (2017-06-07 20:32:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/445014)
3 years, 6 months ago (2017-06-07 21:29:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927823003/1
3 years, 6 months ago (2017-06-07 23:04:44 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 00:14:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/410db21ea84860f814ae4017eaf3...

Powered by Google App Engine
This is Rietveld 408576698